Description
Kyle M Hall
2021-09-28 16:34:50 UTC
Created attachment 125427 [details] [review] Bug 29130 - Holds queue is empty while holds queue builder is running When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets, then starts building the holds queue again. It seems sensible to build the holds queue using temporary tables and copy the data over afterward. Test Plan: 1) Apply this patch 2) Run the holds queue builder 3) Verify holds queue was was populated Created attachment 125430 [details] [review] Bug 29130 - Holds queue is empty while holds queue builder is running When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets, then starts building the holds queue again. It seems sensible to build the holds queue using temporary tables and copy the data over afterward. Test Plan: 1) Apply this patch 2) Run the holds queue builder 3) Verify holds queue was was populated Created attachment 125431 [details] [review] Bug 29130 - Holds queue is empty while holds queue builder is running When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets, then starts building the holds queue again. It seems sensible to build the holds queue using temporary tables and copy the data over afterward. Test Plan: 1) Apply this patch 2) Run the holds queue builder 3) Verify holds queue was was populated Created attachment 125432 [details] [review] Bug 29130 - Holds queue is empty while holds queue builder is running When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets, then starts building the holds queue again. It seems sensible to build the holds queue using temporary tables and copy the data over afterward. Test Plan: 1) Apply this patch 2) Run the holds queue builder 3) Verify holds queue was was populated 4) prove t/db_dependent/HoldsQueue.t Created attachment 126215 [details] [review] Bug 29130 - Holds queue is empty while holds queue builder is running When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets, then starts building the holds queue again. It seems sensible to build the holds queue using temporary tables and copy the data over afterward. Test Plan: 1) Apply this patch 2) Run the holds queue builder 3) Verify holds queue was was populated 4) prove t/db_dependent/HoldsQueue.t Created attachment 126224 [details] [review] Bug 29130: Make the temp tables persistent so unit tests can pass Created attachment 126225 [details] [review] Bug 29130: Make the temp tables persistent so unit tests can pass Created attachment 126227 [details] [review] Bug 29130: Make the temp tables persistent so unit tests can pass |