Bug 29130

Summary: Holds queue is empty while holds queue builder is running
Product: Koha Reporter: Kyle M Hall <kyle>
Component: Hold requestsAssignee: Kyle M Hall <kyle>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 29130 - Holds queue is empty while holds queue builder is running
Bug 29130 - Holds queue is empty while holds queue builder is running
Bug 29130 - Holds queue is empty while holds queue builder is running
Bug 29130 - Holds queue is empty while holds queue builder is running
Bug 29130 - Holds queue is empty while holds queue builder is running
Bug 29130: Make the temp tables persistent so unit tests can pass
Bug 29130: Make the temp tables persistent so unit tests can pass
Bug 29130: Make the temp tables persistent so unit tests can pass

Description Kyle M Hall 2021-09-28 16:34:50 UTC
When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets, then starts building the holds queue again. It seems sensible to build the holds queue using temporary tables and copy the data over afterward.
Comment 1 Kyle M Hall 2021-09-28 16:54:48 UTC
Created attachment 125427 [details] [review]
Bug 29130 - Holds queue is empty while holds queue builder is running

When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets,
then starts building the holds queue again.
It seems sensible to build the holds queue using temporary tables and copy the data over afterward.

Test Plan:
1) Apply this patch
2) Run the holds queue builder
3) Verify holds queue was was populated
Comment 2 Kyle M Hall 2021-09-28 17:53:53 UTC
Created attachment 125430 [details] [review]
Bug 29130 - Holds queue is empty while holds queue builder is running

When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets,
then starts building the holds queue again.
It seems sensible to build the holds queue using temporary tables and copy the data over afterward.

Test Plan:
1) Apply this patch
2) Run the holds queue builder
3) Verify holds queue was was populated
Comment 3 Kyle M Hall 2021-09-28 17:55:55 UTC
Created attachment 125431 [details] [review]
Bug 29130 - Holds queue is empty while holds queue builder is running

When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets,
then starts building the holds queue again.
It seems sensible to build the holds queue using temporary tables and copy the data over afterward.

Test Plan:
1) Apply this patch
2) Run the holds queue builder
3) Verify holds queue was was populated
Comment 4 Kyle M Hall 2021-09-28 18:11:30 UTC
Created attachment 125432 [details] [review]
Bug 29130 - Holds queue is empty while holds queue builder is running

When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets,
then starts building the holds queue again.
It seems sensible to build the holds queue using temporary tables and copy the data over afterward.

Test Plan:
1) Apply this patch
2) Run the holds queue builder
3) Verify holds queue was was populated
4) prove t/db_dependent/HoldsQueue.t
Comment 5 Kyle M Hall 2021-10-13 14:57:04 UTC
Created attachment 126215 [details] [review]
Bug 29130 - Holds queue is empty while holds queue builder is running

When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets,
then starts building the holds queue again.
It seems sensible to build the holds queue using temporary tables and copy the data over afterward.

Test Plan:
1) Apply this patch
2) Run the holds queue builder
3) Verify holds queue was was populated
4) prove t/db_dependent/HoldsQueue.t
Comment 6 Kyle M Hall 2021-10-13 16:06:32 UTC
Created attachment 126224 [details] [review]
Bug 29130: Make the temp tables persistent so unit tests can pass
Comment 7 Kyle M Hall 2021-10-13 16:08:36 UTC
Created attachment 126225 [details] [review]
Bug 29130: Make the temp tables persistent so unit tests can pass
Comment 8 Kyle M Hall 2021-10-13 16:47:09 UTC
Created attachment 126227 [details] [review]
Bug 29130: Make the temp tables persistent so unit tests can pass
Comment 9 Nick Clemens 2021-10-28 11:04:25 UTC

*** This bug has been marked as a duplicate of bug 29346 ***