Bug 29130 - Holds queue is empty while holds queue builder is running
Summary: Holds queue is empty while holds queue builder is running
Status: RESOLVED DUPLICATE of bug 29346
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-28 16:34 UTC by Kyle M Hall
Modified: 2021-10-28 11:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 29130 - Holds queue is empty while holds queue builder is running (3.12 KB, patch)
2021-09-28 16:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 29130 - Holds queue is empty while holds queue builder is running (3.16 KB, patch)
2021-09-28 17:53 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 29130 - Holds queue is empty while holds queue builder is running (3.25 KB, patch)
2021-09-28 17:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 29130 - Holds queue is empty while holds queue builder is running (3.19 KB, patch)
2021-09-28 18:11 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 29130 - Holds queue is empty while holds queue builder is running (3.28 KB, patch)
2021-10-13 14:57 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 29130: Make the temp tables persistent so unit tests can pass (2.65 KB, patch)
2021-10-13 16:06 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 29130: Make the temp tables persistent so unit tests can pass (3.42 KB, patch)
2021-10-13 16:08 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 29130: Make the temp tables persistent so unit tests can pass (3.42 KB, patch)
2021-10-13 16:47 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2021-09-28 16:34:50 UTC
When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets, then starts building the holds queue again. It seems sensible to build the holds queue using temporary tables and copy the data over afterward.
Comment 1 Kyle M Hall 2021-09-28 16:54:48 UTC
Created attachment 125427 [details] [review]
Bug 29130 - Holds queue is empty while holds queue builder is running

When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets,
then starts building the holds queue again.
It seems sensible to build the holds queue using temporary tables and copy the data over afterward.

Test Plan:
1) Apply this patch
2) Run the holds queue builder
3) Verify holds queue was was populated
Comment 2 Kyle M Hall 2021-09-28 17:53:53 UTC
Created attachment 125430 [details] [review]
Bug 29130 - Holds queue is empty while holds queue builder is running

When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets,
then starts building the holds queue again.
It seems sensible to build the holds queue using temporary tables and copy the data over afterward.

Test Plan:
1) Apply this patch
2) Run the holds queue builder
3) Verify holds queue was was populated
Comment 3 Kyle M Hall 2021-09-28 17:55:55 UTC
Created attachment 125431 [details] [review]
Bug 29130 - Holds queue is empty while holds queue builder is running

When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets,
then starts building the holds queue again.
It seems sensible to build the holds queue using temporary tables and copy the data over afterward.

Test Plan:
1) Apply this patch
2) Run the holds queue builder
3) Verify holds queue was was populated
Comment 4 Kyle M Hall 2021-09-28 18:11:30 UTC
Created attachment 125432 [details] [review]
Bug 29130 - Holds queue is empty while holds queue builder is running

When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets,
then starts building the holds queue again.
It seems sensible to build the holds queue using temporary tables and copy the data over afterward.

Test Plan:
1) Apply this patch
2) Run the holds queue builder
3) Verify holds queue was was populated
4) prove t/db_dependent/HoldsQueue.t
Comment 5 Kyle M Hall 2021-10-13 14:57:04 UTC
Created attachment 126215 [details] [review]
Bug 29130 - Holds queue is empty while holds queue builder is running

When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and hold_fill_targets,
then starts building the holds queue again.
It seems sensible to build the holds queue using temporary tables and copy the data over afterward.

Test Plan:
1) Apply this patch
2) Run the holds queue builder
3) Verify holds queue was was populated
4) prove t/db_dependent/HoldsQueue.t
Comment 6 Kyle M Hall 2021-10-13 16:06:32 UTC
Created attachment 126224 [details] [review]
Bug 29130: Make the temp tables persistent so unit tests can pass
Comment 7 Kyle M Hall 2021-10-13 16:08:36 UTC
Created attachment 126225 [details] [review]
Bug 29130: Make the temp tables persistent so unit tests can pass
Comment 8 Kyle M Hall 2021-10-13 16:47:09 UTC
Created attachment 126227 [details] [review]
Bug 29130: Make the temp tables persistent so unit tests can pass
Comment 9 Nick Clemens 2021-10-28 11:04:25 UTC

*** This bug has been marked as a duplicate of bug 29346 ***