|
Description
Nick Clemens (kidclamp)
2021-10-07 19:20:53 UTC
Created attachment 125913 [details] [review] Bug 29193: Update DataTables option iDisplayLength to pageLength I think what we want is '"paging": false', unless there was a reason that the iDisplayLength was chosen in the first place. The "paging" option is specifically designed to turn off pagination. Created attachment 125961 [details] [review] Bug 29193: Specify paging as false in circ-patron-search-results.js This patch removes paging from patron searches using circ-patron-search-results.js To test: 1 - Browse to a record 2 - Click on the 'Holds' tab 3 - Search for 'a' in patrons 4 - Note you see only 20 results 5 - Sort by name and note that you see different results 6 - Apply patch 7 - Reload page and search 8 - Note you see all results Why don't we provide the full DT controls then? Shouldn't this patron search use the same methods as other patron searches? Created attachment 125984 [details] [review] Bug 29193: Specify paging as false in circ-patron-search-results.js This patch removes paging from patron searches using circ-patron-search-results.js To test: 1 - Browse to a record 2 - Click on the 'Holds' tab 3 - Search for 'a' in patrons 4 - Note you see only 20 results 5 - Sort by name and note that you see different results 6 - Apply patch 7 - Reload page and search 8 - Note you see all results Signed-off-by: Owen Leonard <oleonard@myacpl.org> (In reply to Jonathan Druart from comment #4) > > Shouldn't this patron search use the same methods as other patron searches? Bug 15812 could make this one obsolete. (In reply to Owen Leonard from comment #6) > (In reply to Jonathan Druart from comment #4) > > > > Shouldn't this patron search use the same methods as other patron searches? > > Bug 15812 could make this one obsolete. I've just tested bug 15812 and it resolves the issue for checkout search, but not for the holds page, so I think this one is still a good little fix that would also be easily backportable. Created attachment 126021 [details] [review] Bug 29193: Specify paging as false in circ-patron-search-results.js This patch removes paging from patron searches using circ-patron-search-results.js To test: 1 - Browse to a record 2 - Click on the 'Holds' tab 3 - Search for 'a' in patrons 4 - Note you see only 20 results 5 - Sort by name and note that you see different results 6 - Apply patch 7 - Reload page and search 8 - Note you see all results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 Depends on Bug 28055 not in 20.11.x |