Both of these pages are set to show -1 results, i.e. all results returned While this is not great for performance, it is the expected behavior and has broken in 21.05 and master To recreate: 1 - Checkout 20.11 2 - In checkout search type 'a' 3 - You get all 53 patrons 4 - Checkout master 5 - In checkout search type 'a' 6 - You get 20 patrons 7 - Sort by name 8 - There are more patrons, but you cannot page or find them except by sorting
Created attachment 125913 [details] [review] Bug 29193: Update DataTables option iDisplayLength to pageLength
I think what we want is '"paging": false', unless there was a reason that the iDisplayLength was chosen in the first place. The "paging" option is specifically designed to turn off pagination.
Created attachment 125961 [details] [review] Bug 29193: Specify paging as false in circ-patron-search-results.js This patch removes paging from patron searches using circ-patron-search-results.js To test: 1 - Browse to a record 2 - Click on the 'Holds' tab 3 - Search for 'a' in patrons 4 - Note you see only 20 results 5 - Sort by name and note that you see different results 6 - Apply patch 7 - Reload page and search 8 - Note you see all results
Why don't we provide the full DT controls then? Shouldn't this patron search use the same methods as other patron searches?
Created attachment 125984 [details] [review] Bug 29193: Specify paging as false in circ-patron-search-results.js This patch removes paging from patron searches using circ-patron-search-results.js To test: 1 - Browse to a record 2 - Click on the 'Holds' tab 3 - Search for 'a' in patrons 4 - Note you see only 20 results 5 - Sort by name and note that you see different results 6 - Apply patch 7 - Reload page and search 8 - Note you see all results Signed-off-by: Owen Leonard <oleonard@myacpl.org>
(In reply to Jonathan Druart from comment #4) > > Shouldn't this patron search use the same methods as other patron searches? Bug 15812 could make this one obsolete.
(In reply to Owen Leonard from comment #6) > (In reply to Jonathan Druart from comment #4) > > > > Shouldn't this patron search use the same methods as other patron searches? > > Bug 15812 could make this one obsolete. I've just tested bug 15812 and it resolves the issue for checkout search, but not for the holds page, so I think this one is still a good little fix that would also be easily backportable.
Created attachment 126021 [details] [review] Bug 29193: Specify paging as false in circ-patron-search-results.js This patch removes paging from patron searches using circ-patron-search-results.js To test: 1 - Browse to a record 2 - Click on the 'Holds' tab 3 - Search for 'a' in patrons 4 - Note you see only 20 results 5 - Sort by name and note that you see different results 6 - Apply patch 7 - Reload page and search 8 - Note you see all results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.05
Depends on Bug 28055 not in 20.11.x