Summary: | "hidden" class is not working for DT if column visibility button is used | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle, martin.renvoize |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.05
|
|
Bug Depends on: | 28349 | ||
Bug Blocks: | 28859 | ||
Attachments: |
Bug 29218: Rename .hidden class for DT visibility
Bug 29218: Rename .hidden class for DT visibility |
Description
Jonathan Druart
2021-10-13 08:20:54 UTC
Created attachment 126145 [details] [review] Bug 29218: Rename .hidden class for DT visibility .hidden get the CSS that interferes with DT behaviour .hidden { display: none !important; } Test this patch with bug 28859. Created attachment 127029 [details] [review] Bug 29218: Rename .hidden class for DT visibility .hidden get the CSS that interferes with DT behaviour .hidden { display: none !important; } Test this patch with bug 28859. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> No further cases of 'hidden' classes found on DT the fields. Works as expected and is a clean fix. Going straight for PQA Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 (In reply to Kyle M Hall from comment #5) > Pushed to 21.05.x for 21.05.05 Oh, depends on 28349 that is not in 21.05.x Is it still correct to backport it ? (In reply to Fridolin Somers from comment #6) > (In reply to Kyle M Hall from comment #5) > > Pushed to 21.05.x for 21.05.05 > > Oh, depends on 28349 that is not in 21.05.x > Is it still correct to backport it ? Yes, but you should backport bug 28349. |