| Summary: | 'Pay all fines' should be 'Pay all charges' | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Fines and fees | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, kyle, martin.renvoize |
| Version: | unspecified | Keywords: | Manual |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.05
|
|
| Circulation function: | |||
| Attachments: |
Bug 29309: Make 'Pay all fines' be 'Pay all charges'
Bug 29309: Make 'Pay all fines' be 'Pay all charges' Bug 29309: Make 'Pay all fines' be 'Pay all charges' Bug 29309: (follow-up) Change 'Pay fines' to 'Pay charges' |
||
|
Description
Tomás Cohen Arazi (tcohen)
2021-10-22 15:40:15 UTC
Created attachment 126789 [details] [review] Bug 29309: Make 'Pay all fines' be 'Pay all charges' It is not just fines, it is also fees, etc. To test: 1. Have a patron with debt 2. Go to the circulation page for the patron => FAIL: There's a button saying 'Pay all fines' 3. Apply this patch and reload page => SUCCESS: The button now says 'Pay all charges' 4. Enjoy the new terminology 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 126790 [details] [review] Bug 29309: Make 'Pay all fines' be 'Pay all charges' It is not just fines, it is also fees, etc. To test: 1. Have a patron with debt 2. Go to the circulation page for the patron => FAIL: There's a button saying 'Pay all fines' 3. Apply this patch and reload page => SUCCESS: The button now says 'Pay all charges' 4. Enjoy the new terminology 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> I love it when terminology inconsistencies are fixed up! The current message "Checkouts are BLOCKED because fine balance is OVER THE LIMIT" needs fixing as well - I will create a separate bug for that. (In reply to David Nind from comment #3) > I love it when terminology inconsistencies are fixed up! > > The current message "Checkouts are BLOCKED because fine balance is OVER THE > LIMIT" needs fixing as well - I will create a separate bug for that. Give me the right wording, and I'll write it as a patch on your behalf, as a follow-up here! (In reply to Tomás Cohen Arazi from comment #4) > Give me the right wording, and I'll write it as a patch on your behalf, as a > follow-up here! Options to change "Checkouts are BLOCKED because fine balance is OVER THE LIMIT": 1. Checkouts are BLOCKED because the amount owed is OVER THE LIMIT 2. Checkouts are BLOCKED because outstanding charges are OVER THE LIMIT 3. Checkouts are BLOCKED because the amount outstanding is OVER THE LIMIT 4. Checkouts are BLOCKED because the patron's balance is OVER THE LIMIT 5. Checkouts are BLOCKED because the balance for fees and charges is OVER THE LIMIT I prefer option 4. Thanks Tomás! Created attachment 126792 [details] [review] Bug 29309: Make 'Pay all fines' be 'Pay all charges' It is not just fines, it is also fees, etc. To test: 1. Have a patron with debt 2. Go to the circulation page for the patron => FAIL: There's a button saying 'Pay all fines' 3. Apply this patch and reload page => SUCCESS: The button now says 'Pay all charges' 4. Enjoy the new terminology 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 126793 [details] [review] Bug 29309: (follow-up) Change 'Pay fines' to 'Pay charges' Fixes another occurence of the fines to charges. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! (In reply to David Nind from comment #5) > (In reply to Tomás Cohen Arazi from comment #4) > > > Give me the right wording, and I'll write it as a patch on your behalf, as a > > follow-up here! > > Options to change "Checkouts are BLOCKED because fine balance is OVER THE > LIMIT": > > 1. Checkouts are BLOCKED because the amount owed is OVER THE LIMIT > > 2. Checkouts are BLOCKED because outstanding charges are OVER THE LIMIT > > 3. Checkouts are BLOCKED because the amount outstanding is OVER THE LIMIT > > 4. Checkouts are BLOCKED because the patron's balance is OVER THE LIMIT > > 5. Checkouts are BLOCKED because the balance for fees and charges is OVER > THE LIMIT > > I prefer option 4. > > Thanks Tomás! The problem with these, and the original wording too, is that what we block on depends on preferences.. it's not the total outstanding balance, it's a subset of those charges... so we'd need something more generic I think. (In reply to Martin Renvoize from comment #9) > (In reply to David Nind from comment #5) > > (In reply to Tomás Cohen Arazi from comment #4) > > > > > Give me the right wording, and I'll write it as a patch on your behalf, as a > > > follow-up here! > > > > Options to change "Checkouts are BLOCKED because fine balance is OVER THE > > LIMIT": > > > > 1. Checkouts are BLOCKED because the amount owed is OVER THE LIMIT > > > > 2. Checkouts are BLOCKED because outstanding charges are OVER THE LIMIT > > > > 3. Checkouts are BLOCKED because the amount outstanding is OVER THE LIMIT > > > > 4. Checkouts are BLOCKED because the patron's balance is OVER THE LIMIT > > > > 5. Checkouts are BLOCKED because the balance for fees and charges is OVER > > THE LIMIT > > > > I prefer option 4. > > > > Thanks Tomás! > > The problem with these, and the original wording too, is that what we block > on depends on preferences.. it's not the total outstanding balance, it's a > subset of those charges... so we'd need something more generic I think. Maybe we should address each scenario with the right wording? I'm all for that and willing to help. Pushed to 21.05.x for 21.05.05 I prefer not to push to 20.11.x to minimize translation work. |