Summary: | Cannot reorder facets in staff interface elasticsearch configuration | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Searching - Elasticsearch | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, fridolin.somers, jonathan.druart, mkstephens, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.02,21.05.08
|
|
Circulation function: | |||
Bug Depends on: | 19482 | ||
Bug Blocks: | |||
Attachments: |
Bug 29436: ES mappings not saved if zebra is configured
Bug 29436: ES mappings not saved if zebra is configured Bug 29436: ES mappings not saved if zebra is configured |
Description
Nick Clemens (kidclamp)
2021-11-08 15:33:52 UTC
I actually get this error when searchengine=zebra, and the message is... "elasticsearch_disabled"... Created attachment 127697 [details] [review] Bug 29436: ES mappings not saved if zebra is configured The mappings must be editable even if ES is not turned on yet. Using a separate array to store the errors as we are testing for $@ || @messages. There is still something wrong that should be improve, but this patch should be safe for backport. Looks like it has been caused by commit 975e06bd7c3e198048c60d4a0f9968ba89079de7 Bug 19482: Add support for defining 'mandatory' mappings (In reply to Jonathan Druart from comment #2) > There is still something wrong that should be improve, but this patch > should be safe for backport. hum... bug 19482 comment 70 Created attachment 127824 [details] [review] Bug 29436: ES mappings not saved if zebra is configured The mappings must be editable even if ES is not turned on yet. Using a separate array to store the errors as we are testing for $@ || @messages. There is still something wrong that should be improve, but this patch should be safe for backport. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Looks OK to me. Created attachment 128673 [details] [review] Bug 29436: ES mappings not saved if zebra is configured The mappings must be editable even if ES is not turned on yet. Using a separate array to store the errors as we are testing for $@ || @messages. There is still something wrong that should be improve, but this patch should be safe for backport. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 22.05, thanks to everybody involved [U+1F984] 21.11 log shows this was pushed to 21.11.02. Pushed to 21.05.x for 21.05.08. Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. |