On master: Move author to bottom of list, click save "An error occurred when updating mappings: . " On 21.05 we are seeing that nothing happens when clicking the 'Save' button
I actually get this error when searchengine=zebra, and the message is... "elasticsearch_disabled"...
Created attachment 127697 [details] [review] Bug 29436: ES mappings not saved if zebra is configured The mappings must be editable even if ES is not turned on yet. Using a separate array to store the errors as we are testing for $@ || @messages. There is still something wrong that should be improve, but this patch should be safe for backport.
Looks like it has been caused by commit 975e06bd7c3e198048c60d4a0f9968ba89079de7 Bug 19482: Add support for defining 'mandatory' mappings
(In reply to Jonathan Druart from comment #2) > There is still something wrong that should be improve, but this patch > should be safe for backport. hum... bug 19482 comment 70
Created attachment 127824 [details] [review] Bug 29436: ES mappings not saved if zebra is configured The mappings must be editable even if ES is not turned on yet. Using a separate array to store the errors as we are testing for $@ || @messages. There is still something wrong that should be improve, but this patch should be safe for backport. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Looks OK to me.
Created attachment 128673 [details] [review] Bug 29436: ES mappings not saved if zebra is configured The mappings must be editable even if ES is not turned on yet. Using a separate array to store the errors as we are testing for $@ || @messages. There is still something wrong that should be improve, but this patch should be safe for backport. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
21.11 log shows this was pushed to 21.11.02. Pushed to 21.05.x for 21.05.08.
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.