Bug 29475

Summary: opac-user.pl checks renewability even if patron expired and expired patrons blocked from renewal
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Nick Clemens (kidclamp) 2021-11-13 20:10:59 UTC
Found while working on bug 29474:

CanBookBeRenewed performs a check on whether the patron is blocked from renewing, however, it only does this check for auto_renewals. This would seem like a bug, however, the template opac-user.tt performs a check and simply removes any renewal options at display

opac-renew.pl does the check in the script, so the renewal can stil not be performed, however, checking renewability in opac-user.pl is not optimal for performance