Bug 29475 - opac-user.pl checks renewability even if patron expired and expired patrons blocked from renewal
Summary: opac-user.pl checks renewability even if patron expired and expired patrons b...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-13 20:10 UTC by Nick Clemens (kidclamp)
Modified: 2021-11-13 20:10 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2021-11-13 20:10:59 UTC
Found while working on bug 29474:

CanBookBeRenewed performs a check on whether the patron is blocked from renewing, however, it only does this check for auto_renewals. This would seem like a bug, however, the template opac-user.tt performs a check and simply removes any renewal options at display

opac-renew.pl does the check in the script, so the renewal can stil not be performed, however, checking renewability in opac-user.pl is not optimal for performance