| Summary: | flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrii Nugged <nugged> |
| Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | david, jonathan.druart, kyle, nugged, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes the flatpickr default time defaulting to 12:00 instead of 23:59, which was an unexpected change in behaviour caused by the flatpickr switch.
|
Version(s) released in: |
21.11.00
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 29239, 29394 | ||
| Attachments: |
Bug 29477: Flatpickr - default to 23:59 for the time part
Bug 29477: Flatpickr - default to 23:59 for the time part Bug 29477: Flatpickr - default to 23:59 for the time part |
||
|
Description
Andrii Nugged
2021-11-15 09:14:51 UTC
Created attachment 127623 [details] [review] Bug 29477: Flatpickr - default to 23:59 for the time part It was defaulting to 12:00 which was an unexpected change in behaviour caused by flatpickr switch. Test plan: On the circulation view, check some items out and play with the time part and "Remember for session". The behaviour must be correct, ie. the same as prior to flatpickr switch. Created attachment 127668 [details] [review] Bug 29477: Flatpickr - default to 23:59 for the time part It was defaulting to 12:00 which was an unexpected change in behaviour caused by flatpickr switch. Test plan: On the circulation view, check some items out and play with the time part and "Remember for session". The behaviour must be correct, ie. the same as prior to flatpickr switch. Signed-off-by: David Nind <david@davidnind.com> Created attachment 127687 [details] [review] Bug 29477: Flatpickr - default to 23:59 for the time part It was defaulting to 12:00 which was an unexpected change in behaviour caused by flatpickr switch. Test plan: On the circulation view, check some items out and play with the time part and "Remember for session". The behaviour must be correct, ie. the same as prior to flatpickr switch. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Works as expected, trivial fix. Pushed to master for 21.11, thanks to everybody involved! |