Our customers reported this UX issue: time by default set to the middle of the say (12:00) and they in all cases need to change the time manually to 23:59.
Created attachment 127623 [details] [review] Bug 29477: Flatpickr - default to 23:59 for the time part It was defaulting to 12:00 which was an unexpected change in behaviour caused by flatpickr switch. Test plan: On the circulation view, check some items out and play with the time part and "Remember for session". The behaviour must be correct, ie. the same as prior to flatpickr switch.
Created attachment 127668 [details] [review] Bug 29477: Flatpickr - default to 23:59 for the time part It was defaulting to 12:00 which was an unexpected change in behaviour caused by flatpickr switch. Test plan: On the circulation view, check some items out and play with the time part and "Remember for session". The behaviour must be correct, ie. the same as prior to flatpickr switch. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 127687 [details] [review] Bug 29477: Flatpickr - default to 23:59 for the time part It was defaulting to 12:00 which was an unexpected change in behaviour caused by flatpickr switch. Test plan: On the circulation view, check some items out and play with the time part and "Remember for session". The behaviour must be correct, ie. the same as prior to flatpickr switch. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Works as expected, trivial fix.
Pushed to master for 21.11, thanks to everybody involved!