| Summary: | Don't require title for HTML customizations | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | OPAC | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | barbara.johnson, catrina, dcook, fridolin.somers, jonathan.druart, kyle, lucas, m.de.rooy, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29518 |
||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 24387 | ||
| Bug Blocks: | 30272 | ||
| Attachments: |
Bug 29515: Make title for HTML customizations optional
Bug 29515: Make title for HTML customizations optional Bug 29515: Make title for HTML customizations optional |
||
|
Description
Katrin Fischer
2021-11-18 11:37:12 UTC
We have discussed on IRC and some HTML customizations like OpacLoginInstructions can display the title, but not all of them. We concluded that having the field optional would work well. +1 if you work in this area a lot its becomes a bit tedious to always have to add a superfluous title (In reply to Lucas Gass from comment #2) > +1 > > if you work in this area a lot its becomes a bit tedious to always have to > add a superfluous title I've recently noticed that I can just enter an empty space but it is very annoying... Created attachment 127861 [details] [review] Bug 29515: Make title for HTML customizations optional This adds code to make the title field for HTML customizations optional while it stays mandatory for news entries. 1) Add a new HTML customization, verify you are forced to enter a title 2) Apply patch 3) Repeat and verify that you can now save without title 4) Add a new news entry 5) Verify that the title field remained mandatory there. Created attachment 127898 [details] [review] Bug 29515: Make title for HTML customizations optional This adds code to make the title field for HTML customizations optional while it stays mandatory for news entries. 1) Add a new HTML customization, verify you are forced to enter a title 2) Apply patch 3) Repeat and verify that you can now save without title 4) Add a new news entry 5) Verify that the title field remained mandatory there. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 130424 [details] [review] Bug 29515: Make title for HTML customizations optional This adds code to make the title field for HTML customizations optional while it stays mandatory for news entries. 1) Add a new HTML customization, verify you are forced to enter a title 2) Apply patch 3) Repeat and verify that you can now save without title 4) Add a new news entry 5) Verify that the title field remained mandatory there. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> All appears to continue to work.. I'm not entirely sure why title was required in the first place though.. it's not required for languages other than 'default' ? Passing QA This is not really enhancement. I think it should be backported at least on stable 21.11.x Pushed to master for 22.05, thanks to everybody involved [U+1F984] Is this working? Additional contents are not created if the title is not filled in. I experience the same thing as Jonathan. The "+New entry" doesn't save if there isn't a title entered. I recently found this broken again too. This area appears rather fragile, I'm sure when I QA'd this bug it was working, but lots has moved again since. |