| Summary: | Unecessary GetMarcBiblio call in Koha::UI::Form::Builder::Item (?) | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | In Discussion --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | m.de.rooy, nugged |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
|
Description
Jonathan Druart
2021-12-03 14:21:25 UTC
It looks like there are only mentions of GetMarcBiblio in comments now - is this still valid? Yes, the suggestion is still valid and can still be implemented. We now have:
my $marc_record = $biblio ? $biblio->metadata->record : undef;
I would be hesitant to remove it. It is not unlikely that a custom cataloguing plugin needs $record for something.
There is no real need to remove it?
(In reply to Marcel de Rooy from comment #3) > We now have: > my $marc_record = $biblio ? $biblio->metadata->record : undef; > > I would be hesitant to remove it. It is not unlikely that a custom > cataloguing plugin needs $record for something. As said previously, I didn't find any. > There is no real need to remove it? Unnecessary processing? |