Andrew contacted me to raise a potential problem coming from bug 27526: commit 7a8357f7099d0863a322d1e91741b792b97fd6e1 Bug 27526: Adjust code to use Koha::Items -C4::Biblio::EmbedItemsInMarcBiblio({ - marc_record => $temp, - biblionumber => $biblionumber }); has been removed. I have tried to know where the items subfields could be used and found, in Koha/UI/Form/Builder/Item.pm: 1. only if itemcallnumber is used 164 my $temp2 = $marc_record->field($CNtag); 2. cataloguing plugins: 316 record => $marc_record, I have not found any cataloguing plugins using the MARC::Record (some are retrieving it when they have been passed in parameter, but that's another story). So maybe we could: * Remove marc_record from generate_subfield_form param list * Fetch it in the itemcallnumber block * Remove it from the cataloguing plugins
It looks like there are only mentions of GetMarcBiblio in comments now - is this still valid?
Yes, the suggestion is still valid and can still be implemented.
We now have: my $marc_record = $biblio ? $biblio->metadata->record : undef; I would be hesitant to remove it. It is not unlikely that a custom cataloguing plugin needs $record for something. There is no real need to remove it?
(In reply to Marcel de Rooy from comment #3) > We now have: > my $marc_record = $biblio ? $biblio->metadata->record : undef; > > I would be hesitant to remove it. It is not unlikely that a custom > cataloguing plugin needs $record for something. As said previously, I didn't find any. > There is no real need to remove it? Unnecessary processing?