| Summary: | Patron batch modification tool - mobile phone number column naming | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Nind <david> |
| Component: | Tools | Assignee: | Philip Orr <philip.orr> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | jonathan.druart, lucas, philip.orr |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02,22.11.08
|
|
| Circulation function: | |||
| Attachments: |
Bug 29762: Change field names from "Mobile" to "Other phone"
Bug 29762: Change field names from "Mobile" to "Other phone" Bug 29762: Change field names from "Mobile" to "Other phone" Bug 29762: (follow-up) Change field names from phone to primary phone |
||
|
Description
David Nind
2021-12-23 05:36:01 UTC
Yes, should be renamed "Other phone" Created attachment 153181 [details] [review] Bug 29762: Change field names from "Mobile" to "Other phone" This Patch changes the field name for "Mobile" to "Other phone" in Patron batch modification. To test: 1. Apply the patch 2. Go to Tools -> Batch Patron Modification and add some patrons 3. Hit "continue" 4. Verify that in the list of patrons you selected, the field "Mobile" has been replaced by the field "Other phone" 5. Verify that down below in the fields to be batch modified, the field "Mobile" has also been replaced by the field "Other phone" 6. Add some data into the field "Other phone" (e.g. 12345 or some other number) and hit save 7. Confirm that the field was correctly modified and is still named "Other phone" Just a quick note on this patch: I only changed the name of the field in modborrowers.tt, I made no changes to the database. The actual database field in borrowers that is displayed in "Other phone" is (possibly confusingly) named borrowers.mobile. Created attachment 153192 [details] [review] Bug 29762: Change field names from "Mobile" to "Other phone" This Patch changes the field name for "Mobile" to "Other phone" in Patron batch modification. To test: 1. Apply the patch 2. Go to Tools -> Batch Patron Modification and add some patrons 3. Hit "continue" 4. Verify that in the list of patrons you selected, the field "Mobile" has been replaced by the field "Other phone" 5. Verify that down below in the fields to be batch modified, the field "Mobile" has also been replaced by the field "Other phone" 6. Add some data into the field "Other phone" (e.g. 12345 or some other number) and hit save 7. Confirm that the field was correctly modified and is still named "Other phone" Signed-off-by: Sam Lau <samalau@gmail.com> (In reply to Philip Orr from comment #3) > Just a quick note on this patch: I only changed the name of the field in > modborrowers.tt, I made no changes to the database. The actual database > field in borrowers that is displayed in "Other phone" is (possibly > confusingly) named borrowers.mobile. That's confusing, but ok. We try to make the descriptions match between the normal patron form and the batch patron modification. Other phone in GUI is mobile in the database since some renaming of fields took place a long while ago. Created attachment 153218 [details] [review] Bug 29762: Change field names from "Mobile" to "Other phone" This Patch changes the field name for "Mobile" to "Other phone" in Patron batch modification. To test: 1. Apply the patch 2. Go to Tools -> Batch Patron Modification and add some patrons 3. Hit "continue" 4. Verify that in the list of patrons you selected, the field "Mobile" has been replaced by the field "Other phone" 5. Verify that down below in the fields to be batch modified, the field "Mobile" has also been replaced by the field "Other phone" 6. Add some data into the field "Other phone" (e.g. 12345 or some other number) and hit save 7. Confirm that the field was correctly modified and is still named "Other phone" Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 153219 [details] [review] Bug 29762: (follow-up) Change field names from phone to primary phone This change is made in order to make sure that the labels on the normal patron form and the batch patron edit tool match up. Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to oldstable for 22.11.x |