Bug 29762 - Patron batch modification tool - mobile phone number column naming
Summary: Patron batch modification tool - mobile phone number column naming
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Philip Orr
QA Contact: Katrin Fischer
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2021-12-23 05:36 UTC by David Nind
Modified: 2023-09-13 20:39 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 29762: Change field names from "Mobile" to "Other phone" (2.59 KB, patch)
2023-07-07 13:33 UTC, Philip Orr
Details | Diff | Splinter Review
Bug 29762: Change field names from "Mobile" to "Other phone" (2.63 KB, patch)
2023-07-07 16:26 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 29762: Change field names from "Mobile" to "Other phone" (2.69 KB, patch)
2023-07-09 14:09 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 29762: (follow-up) Change field names from phone to primary phone (2.11 KB, patch)
2023-07-09 14:10 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Nind 2021-12-23 05:36:01 UTC
When modifying patron information using the patron batch modification tool (Tools > Patrons > Patron batch modification), the listing pages after entering either card numbers or borrower numbers have a 'Mobile' column.

This matches to 'Other phone' in the contact information section when editing patron information. 

This is not the same as the SMS number when SMS for messages is enabled.

Should this remain as 'Mobile" or be changed to match the patron information field title? Or vice versa?

This was identified when testing bug 23291 - Patron batch modification based on SMS number.
Comment 1 Jonathan Druart 2022-02-17 16:14:02 UTC
Yes, should be renamed "Other phone"
Comment 2 Philip Orr 2023-07-07 13:33:26 UTC
Created attachment 153181 [details] [review]
Bug 29762: Change field names from "Mobile" to "Other phone"

This Patch changes the field name for "Mobile" to "Other phone"
in Patron batch modification.

To test:
1. Apply the patch
2. Go to Tools -> Batch Patron Modification and add some patrons
3. Hit "continue"
4. Verify that in the list of patrons you selected, the field
"Mobile" has been replaced by the field "Other phone"
5. Verify that down below in the fields to be batch modified,
the field "Mobile" has also been replaced by the field "Other
phone"
6. Add some data into the field "Other phone" (e.g. 12345 or
some other number) and hit save
7. Confirm that the field was correctly modified and is still
named "Other phone"
Comment 3 Philip Orr 2023-07-07 13:35:57 UTC
Just a quick note on this patch: I only changed the name of the field in modborrowers.tt, I made no changes to the database. The actual database field in borrowers that is displayed in "Other phone" is (possibly confusingly) named borrowers.mobile.
Comment 4 Sam Lau 2023-07-07 16:26:19 UTC
Created attachment 153192 [details] [review]
Bug 29762: Change field names from "Mobile" to "Other phone"

This Patch changes the field name for "Mobile" to "Other phone"
in Patron batch modification.

To test:
1. Apply the patch
2. Go to Tools -> Batch Patron Modification and add some patrons
3. Hit "continue"
4. Verify that in the list of patrons you selected, the field
"Mobile" has been replaced by the field "Other phone"
5. Verify that down below in the fields to be batch modified,
the field "Mobile" has also been replaced by the field "Other
phone"
6. Add some data into the field "Other phone" (e.g. 12345 or
some other number) and hit save
7. Confirm that the field was correctly modified and is still
named "Other phone"

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 5 Katrin Fischer 2023-07-09 14:05:28 UTC
(In reply to Philip Orr from comment #3)
> Just a quick note on this patch: I only changed the name of the field in
> modborrowers.tt, I made no changes to the database. The actual database
> field in borrowers that is displayed in "Other phone" is (possibly
> confusingly) named borrowers.mobile.

That's confusing, but ok. We try to make the descriptions match between the normal patron form and the batch patron modification. Other phone in GUI is mobile in the database since some renaming of fields took place a long while ago.
Comment 6 Katrin Fischer 2023-07-09 14:09:58 UTC
Created attachment 153218 [details] [review]
Bug 29762: Change field names from "Mobile" to "Other phone"

This Patch changes the field name for "Mobile" to "Other phone"
in Patron batch modification.

To test:
1. Apply the patch
2. Go to Tools -> Batch Patron Modification and add some patrons
3. Hit "continue"
4. Verify that in the list of patrons you selected, the field
"Mobile" has been replaced by the field "Other phone"
5. Verify that down below in the fields to be batch modified,
the field "Mobile" has also been replaced by the field "Other
phone"
6. Add some data into the field "Other phone" (e.g. 12345 or
some other number) and hit save
7. Confirm that the field was correctly modified and is still
named "Other phone"

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2023-07-09 14:10:01 UTC
Created attachment 153219 [details] [review]
Bug 29762: (follow-up) Change field names from phone to primary phone

This change is made in order to make sure that the labels on the
normal patron form and the batch patron edit tool match up.
Comment 8 Tomás Cohen Arazi 2023-07-14 19:40:41 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Martin Renvoize 2023-07-18 11:51:56 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 10 Matt Blenkinsop 2023-07-18 15:28:50 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x