Summary: | JS error during installer | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, gmcharlt, kyle, martin.renvoize |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.03
|
|
Circulation function: | |||
Bug Depends on: | 28376, 28982 | ||
Bug Blocks: | |||
Attachments: |
Bug 29837: Remove JS error during installer
Bug 29837: Remove JS error during installer Bug 29837: Remove JS error during installer |
Description
Jonathan Druart
2022-01-10 09:35:35 UTC
Created attachment 129241 [details] [review] Bug 29837: Remove JS error during installer Uncaught ReferenceError: _ is not defined the _() function is called from calendar.inc, but calendar.inc is included before the definition of this function in installer-intranet-bottom.inc Test plan: Confirm that the JS error is gone Created attachment 129249 [details] [review] Bug 29837: Remove JS error during installer Uncaught ReferenceError: _ is not defined the _() function is called from calendar.inc, but calendar.inc is included before the definition of this function in installer-intranet-bottom.inc Test plan: Confirm that the JS error is gone Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 129596 [details] [review] Bug 29837: Remove JS error during installer Uncaught ReferenceError: _ is not defined the _() function is called from calendar.inc, but calendar.inc is included before the definition of this function in installer-intranet-bottom.inc Test plan: Confirm that the JS error is gone Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice work, Passing QA Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.03 Missing dependency, not backported to 21.05 |