There is one datepicker instance in the onboarding templates which should be replaced with Flatpickr.
Created attachment 124716 [details] [review] Bug 28982: Use Flatpickr on onboarding pages This patch replaces the use of jQueryUI's datepicker in the onboarding templates. The addition of calendar.inc to the template requires that some additions be made to the installer's header files, adding the i18n JavaScript assets. jQueryUI-specific CSS is removed from installer.scss, and inclusion of Flatpickr's SCSS is added. To test, apply the patch and rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Start the installation process. - Continue through the installation process until you reach the stage in onboarding where you are creating a patron category. - The "Enrollment period -> Until" field should be a Flatpickr calendar widget. The widget should look and work correctly.
Created attachment 125503 [details] [review] Bug 28982: Use Flatpickr on onboarding pages This patch replaces the use of jQueryUI's datepicker in the onboarding templates. The addition of calendar.inc to the template requires that some additions be made to the installer's header files, adding the i18n JavaScript assets. jQueryUI-specific CSS is removed from installer.scss, and inclusion of Flatpickr's SCSS is added. To test, apply the patch and rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Start the installation process. - Continue through the installation process until you reach the stage in onboarding where you are creating a patron category. - The "Enrollment period -> Until" field should be a Flatpickr calendar widget. The widget should look and work correctly. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
All works for me.. Signing off
Created attachment 125656 [details] [review] Bug 28978: Convert installer CSS to SCSS This patch creates a new SCSS file, installer.scss, from which installer.css will be compiled. Most of the resulting CSS is unchanged, but some minor sections were removed because they were obsolete. The jQueryUI-specific section isn't fully converted to SCSS because it's going to go away with the addition of Flatpickr. To test, apply the patch and rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Confirm that koha-tmpl/intranet-tmpl/prog/css/installer.css is updated. - Go through the complete web installation process, including onboarding, to confirm that everything is styled as before. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This appears to work quite well, but there is a small glitch I am wondering about: * Onboarding, where you set up a patron category * Set an until date for the expiration date * The date in the input field shows in the database format (2021-10-19) * Below is a format with: (MM/DD/YYYY) Could you please check?
Created attachment 125710 [details] [review] Bug 28982: (follow-up) Ensure that date format is correctly checked This patch modifies the global calendar include so that it doesn't use the potentially-undefined template variable "dateformat."
Hi Owen, a little confused about the fix: When we are at the stage of "onboarding" the system preferences and possible also custom.sql changes for changing it (de-DE does) have already been run. So I think it should not be undefined at this point. Also, I believe it's not the hint that is off, but the input is displaying the database format, that is not our default ... so maybe a problem for a different bug actually?
It wasn't that the dateformat preference wasn't available to the template before my follow-up, it was that the include file tried to reference a global JavaScript variable, "dateformat" which wasn't available. The revision makes it so that the system preference is correctly defined in JavaScript.
Created attachment 127138 [details] [review] Bug 28982: Use Flatpickr on onboarding pages This patch replaces the use of jQueryUI's datepicker in the onboarding templates. The addition of calendar.inc to the template requires that some additions be made to the installer's header files, adding the i18n JavaScript assets. jQueryUI-specific CSS is removed from installer.scss, and inclusion of Flatpickr's SCSS is added. To test, apply the patch and rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Start the installation process. - Continue through the installation process until you reach the stage in onboarding where you are creating a patron category. - The "Enrollment period -> Until" field should be a Flatpickr calendar widget. The widget should look and work correctly. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 127139 [details] [review] Bug 28982: (follow-up) Ensure that date format is correctly checked This patch modifies the global calendar include so that it doesn't use the potentially-undefined template variable "dateformat." Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!