| Summary: | opac-reserve explodes if invalid biblionumber is passed | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, kyle, tomascohen, victor |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.03,21.05.11
|
|
| Circulation function: | |||
| Attachments: |
Bug 29840: Deal with non-existing biblionumber in opac-reserve
Bug 29840: Deal with non-existing biblionumber in opac-reserve Bug 29840: Deal with non-existing biblionumber in opac-reserve |
||
|
Description
Jonathan Druart
2022-01-10 13:02:28 UTC
Created attachment 129256 [details] [review] Bug 29840: Deal with non-existing biblionumber in opac-reserve We should not explode if the biblionumber passed in not in DB. Test plan: Hit /cgi-bin/koha/opac-reserve.pl?biblionumber=42424 and notice the error message. Without this patch you got Can't call method "holds" on an undefined value at /kohadevbox/koha/opac/opac-reserve.pl line 172 Created attachment 129320 [details] [review] Bug 29840: Deal with non-existing biblionumber in opac-reserve We should not explode if the biblionumber passed in not in DB. Test plan: Hit /cgi-bin/koha/opac-reserve.pl?biblionumber=42424 and notice the error message. Without this patch you got Can't call method "holds" on an undefined value at /kohadevbox/koha/opac/opac-reserve.pl line 172 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 129483 [details] [review] Bug 29840: Deal with non-existing biblionumber in opac-reserve We should not explode if the biblionumber passed in not in DB. Test plan: Hit /cgi-bin/koha/opac-reserve.pl?biblionumber=42424 and notice the error message. Without this patch you got Can't call method "holds" on an undefined value at /kohadevbox/koha/opac/opac-reserve.pl line 172 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.03 Pushed to 21.05.x for 21.05.11 Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. |