| Summary: | Make the ES config more flexible | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Searching - Elasticsearch | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, kyle, martin.renvoize, tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 29856: Make the ES config more flexible
Bug 29856: Make the ES config more flexible Bug 29856: Make the ES config more flexible Bug 29856: Make the ES config more flexible |
||
|
Description
Jonathan Druart
2022-01-12 08:46:34 UTC
Created attachment 129327 [details] [review] Bug 29856: Make the ES config more flexible I need to add a 'request_timeout' entry to the ES configuration to fix some timeout problems on the sandboxes. Instead of hard coding this new option it seems preferable to be flexible and allow different options to be passed from the config file. Test plan: Add to the $KOHA_CONF, inside the elasticsearch section <request_timeout>60</request_timeout> Rebuild the ES index koha-elasticsearch --rebuild kohadev Change the value of the timeout to 1 Rebuild the index It should fail (with a quite bad error 'Bad response received when submitting request to Elasticsearch') Can I get this patch pushed quickly please? It will help to fix the BibLibre's sandboxes. Created attachment 129328 [details] [review] Bug 29856: Make the ES config more flexible I need to add a 'request_timeout' entry to the ES configuration to fix some timeout problems on the sandboxes. Instead of hard coding this new option it seems preferable to be flexible and allow different options to be passed from the config file. Test plan: Add to the $KOHA_CONF, inside the elasticsearch section <request_timeout>60</request_timeout> Rebuild the ES index koha-elasticsearch --rebuild kohadev Change the value of the timeout to 1 Rebuild the index It should fail (with a quite bad error 'Bad response received when submitting request to Elasticsearch') *** Bug 29854 has been marked as a duplicate of this bug. *** Created attachment 129347 [details] [review] Bug 29856: Make the ES config more flexible I need to add a 'request_timeout' entry to the ES configuration to fix some timeout problems on the sandboxes. Instead of hard coding this new option it seems preferable to be flexible and allow different options to be passed from the config file. Test plan: Add to the $KOHA_CONF, inside the elasticsearch section <request_timeout>60</request_timeout> Rebuild the ES index koha-elasticsearch --rebuild kohadev Change the value of the timeout to 1 Rebuild the index It should fail (with a quite bad error 'Bad response received when submitting request to Elasticsearch') Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This is nice and works as described. Signing off Created attachment 129349 [details] [review] Bug 29856: Make the ES config more flexible I need to add a 'request_timeout' entry to the ES configuration to fix some timeout problems on the sandboxes. Instead of hard coding this new option it seems preferable to be flexible and allow different options to be passed from the config file. Test plan: Add to the $KOHA_CONF, inside the elasticsearch section <request_timeout>60</request_timeout> Rebuild the ES index koha-elasticsearch --rebuild kohadev Change the value of the timeout to 1 Rebuild the index It should fail (with a quite bad error 'Bad response received when submitting request to Elasticsearch') Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> FTR: It seems Search::Elasticsearch doesn't break on weird/invalid configurations passed. Pushed to master for 22.05, thanks to everybody involved [U+1F984] |