Summary: | Filter Paid Transactions Broken on Transactions tab in Staff | ||
---|---|---|---|
Product: | Koha | Reporter: | Lisette Scheer <lisettepalouse+koha> |
Component: | Fines and fees | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | andrewfh, david, kyle, oleonard, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the "Filter paid transactions" link in the staff interface on the Patron account > Accounting > Transactions tab. It now correctly filters the list of transactions - only transactions with an outstanding amount greater than zero are shown ("Show all transactions" clears the filter). Before this fix, clicking on the link didn't do anything and didn't filter any of the transactions as expected.
|
Version(s) released in: |
22.05.00,21.11.03,21.05.11
|
Attachments: |
Bug 29952: [20.11.x] Replace obsolete DataTable column filter function
Bug 29952: Replace obsolete DataTable column filter function Bug 29952: [20.11.x] Replace obsolete DataTable column filter function Bug 29952: Replace obsolete DataTable column filter function Bug 29952: Replace obsolete DataTable column filter function |
Description
Lisette Scheer
2022-01-26 22:33:24 UTC
It's also broken on 20.11 - thx for the bug Lisette, it kept escaping from my list. Created attachment 129873 [details] [review] Bug 29952: [20.11.x] Replace obsolete DataTable column filter function The "Filter paid transactions" link on the Accounting -> Transactions page is broken because it uses an obsolete DataTables function for filtering. This patch updates it to use the current syntax, available in DataTables since version 1.10. To test, apply the patch and locate a patron in the staff interface who has multiple fines, some paid. - View the patron's "Accounting" page and click the "Transactions" tab. - Click the "Filter paid transactions" link. The table should be filtered so that only transactions with an outstanding amount > zero are shown. - The filter link should change to read "Show all transactions." - Clicking "Show all transactions" should clear the filter. - Test with one or more columns hidden using the "Columns" control. Filtering should still work correctly with columns hidden. Created attachment 129874 [details] [review] Bug 29952: Replace obsolete DataTable column filter function The "Filter paid transactions" link on the Accounting -> Transactions page is broken because it uses an obsolete DataTables function for filtering. This patch updates it to use the current syntax, available in DataTables since version 1.10. To test, apply the patch and locate a patron in the staff interface who has multiple fines, some paid. - View the patron's "Accounting" page and click the "Transactions" tab. - Click the "Filter paid transactions" link. The table should be filtered so that only transactions with an outstanding amount > zero are shown. - The filter link should change to read "Show all transactions." - Clicking "Show all transactions" should clear the filter. - Test with one or more columns hidden using the "Columns" control. Filtering should still work correctly with columns hidden. The table no longer appears to be a datatable, just a regular table. The console gives me the following error: boraccount.pl:1596 Uncaught SyntaxError: Unexpected token '<<' This is line 1596 in the source code: <<<<<<< HEAD Lisette (In reply to Lisette Scheer from comment #4) > This is line 1596 in the source code: > <<<<<<< HEAD This bug report has two patches, one for master and one for 20.11.x. Applying both will cause a conflict. Created attachment 130041 [details] [review] Bug 29952: [20.11.x] Replace obsolete DataTable column filter function The "Filter paid transactions" link on the Accounting -> Transactions page is broken because it uses an obsolete DataTables function for filtering. This patch updates it to use the current syntax, available in DataTables since version 1.10. To test, apply the patch and locate a patron in the staff interface who has multiple fines, some paid. - View the patron's "Accounting" page and click the "Transactions" tab. - Click the "Filter paid transactions" link. The table should be filtered so that only transactions with an outstanding amount > zero are shown. - The filter link should change to read "Show all transactions." - Clicking "Show all transactions" should clear the filter. - Test with one or more columns hidden using the "Columns" control. Filtering should still work correctly with columns hidden. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Tested the 20.11 patch and it works like a charm, thx! Created attachment 130160 [details] [review] Bug 29952: Replace obsolete DataTable column filter function The "Filter paid transactions" link on the Accounting -> Transactions page is broken because it uses an obsolete DataTables function for filtering. This patch updates it to use the current syntax, available in DataTables since version 1.10. To test, apply the patch and locate a patron in the staff interface who has multiple fines, some paid. - View the patron's "Accounting" page and click the "Transactions" tab. - Click the "Filter paid transactions" link. The table should be filtered so that only transactions with an outstanding amount > zero are shown. - The filter link should change to read "Show all transactions." - Clicking "Show all transactions" should clear the filter. - Test with one or more columns hidden using the "Columns" control. Filtering should still work correctly with columns hidden. Signed-off-by: David Nind <david@davidnind.com> Tested and signed off the patch for master (20.11 patch already tested by Katrin). Created attachment 130333 [details] [review] Bug 29952: Replace obsolete DataTable column filter function The "Filter paid transactions" link on the Accounting -> Transactions page is broken because it uses an obsolete DataTables function for filtering. This patch updates it to use the current syntax, available in DataTables since version 1.10. To test, apply the patch and locate a patron in the staff interface who has multiple fines, some paid. - View the patron's "Accounting" page and click the "Transactions" tab. - Click the "Filter paid transactions" link. The table should be filtered so that only transactions with an outstanding amount > zero are shown. - The filter link should change to read "Show all transactions." - Clicking "Show all transactions" should clear the filter. - Test with one or more columns hidden using the "Columns" control. Filtering should still work correctly with columns hidden. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.05, thanks to everybody involved 🦄 Pushed to 21.11.x for 21.11.03 Pushed to 21.05.x for 21.05.11 Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. (In reply to Victor Grousset/tuxayo from comment #14) > Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. It is actually, but maybe a little late now :) I should still be able to backport and push to the branch. Does that help? Sure :) Sorry, I don't have the rights for the branch anymore. I just applied the 20.11.x patch locally but couldn't test it because something is wrong with my local koha environment. (In reply to Victor Grousset/tuxayo from comment #18) > Sorry, I don't have the rights for the branch anymore. I just applied the > 20.11.x patch locally but couldn't test it because something is wrong with > my local koha environment. Sorry, that's on me. I was looking at the 22.05 roles page... not realizing that 20.11 is already EOL. |