| Summary: | Fix C4::Context->unset_userenv and rename _new too | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | ASSIGNED --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, dcook, fridolin.somers, jonathan.druart, lucas, m.de.rooy, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 29915 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 29954: Make new_userenv and unset_userenv consistent
Bug 29954: Rename _unset calls to unset Bug 29954: Rename _new calls to new Bug 29954: Fix calls in Auth.pm |
||
|
Description
Marcel de Rooy
2022-01-27 09:54:16 UTC
Moving this TEMPORARILY to Koha sec since it depends on stuff. Created attachment 129867 [details] [review] Bug 29954: Make new_userenv and unset_userenv consistent Remove the underscore; not a private routine. Created attachment 129868 [details] [review] Bug 29954: Rename _unset calls to unset Created attachment 129869 [details] [review] Bug 29954: Rename _new calls to new Created attachment 129870 [details] [review] Bug 29954: Fix calls in Auth.pm Back to class method calls (temporary fix from 29915). This will need to wait a bit on the other secu bugs and 29915 Sweet. I like it. Do we have any tests for these? (In reply to David Cook from comment #7) > Sweet. I like it. > > Do we have any tests for these? See 29915 in relation to check_cookie_auth. |