Bug 29954 - Fix C4::Context->unset_userenv and rename _new too
Summary: Fix C4::Context->unset_userenv and rename _new too
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on: 29915
Blocks:
  Show dependency tree / graph
 
Reported: 2022-01-27 09:54 UTC by Marcel de Rooy
Modified: 2022-04-07 08:23 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 29954: Make new_userenv and unset_userenv consistent (2.01 KB, patch)
2022-01-27 11:11 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 29954: Rename _unset calls to unset (3.14 KB, patch)
2022-01-27 11:11 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 29954: Rename _new calls to new (9.99 KB, patch)
2022-01-27 11:11 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 29954: Fix calls in Auth.pm (2.42 KB, patch)
2022-01-27 11:11 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2022-01-27 09:54:16 UTC 
Make parameters consistent. This routine does not have a class parameter like new_userenv does.
Comment 1 Marcel de Rooy 2022-01-27 11:10:46 UTC 
Moving this TEMPORARILY to Koha sec since it depends on stuff.
Comment 2 Marcel de Rooy 2022-01-27 11:11:29 UTC 
Created attachment 129867 [details] [review]
Bug 29954: Make new_userenv and unset_userenv consistent

Remove the underscore; not a private routine.
Comment 3 Marcel de Rooy 2022-01-27 11:11:33 UTC 
Created attachment 129868 [details] [review]
Bug 29954: Rename _unset calls to unset
Comment 4 Marcel de Rooy 2022-01-27 11:11:37 UTC 
Created attachment 129869 [details] [review]
Bug 29954: Rename _new calls to new
Comment 5 Marcel de Rooy 2022-01-27 11:11:41 UTC 
Created attachment 129870 [details] [review]
Bug 29954: Fix calls in Auth.pm

Back to class method calls (temporary fix from 29915).
Comment 6 Marcel de Rooy 2022-01-27 11:12:11 UTC 
This will need to wait a bit on the other secu bugs and 29915
Comment 7 David Cook 2022-01-28 00:20:00 UTC 
Sweet. I like it.

Do we have any tests for these?
Comment 8 Marcel de Rooy 2022-01-28 07:07:59 UTC 
(In reply to David Cook from comment #7)
> Sweet. I like it.
> 
> Do we have any tests for these?

See 29915 in relation to check_cookie_auth.