| Summary: | Show itemtype in holds table on patron details | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Magnus Enger <magnus> |
| Component: | Hold requests | Assignee: | Bugs List <koha-bugs> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 29982 - Show itemtype in holds table on patron details
screenshot of columns after patch Bug 29982: Show itemtype in holds table on patron details Bug 29982: Show itemtype in holds table on patron details |
||
|
Description
Magnus Enger
2022-01-31 10:27:19 UTC
This feature has been requested by Swedish libraries, in order to make it easier to distinguish holds related to inter library loans in the holds tables. Created attachment 129995 [details] [review] Bug 29982 - Show itemtype in holds table on patron details Show item type in the holds tables on "Check out" and "Details" tabs in the intranet. To test: - Add an item level hold - Go to patron details and look at the "Check out" tab - Click on the "Holds" horizontal tab and verify the item type is shown in a column between "Title" and "Call number" - Go to the "Details" tab - Click on the "Holds" horizontal tab and verify the display is the same as above - Make a record level hold and verify the item type is not shown in the tables described above - Check in an item from the record level hold, so it is "waiting" for the patron - Verify the item type is now shown in the same way as for the item level hold, as described above When I apply this patch and look at the table on either Check out or Details subsequent columns do not look right. Created attachment 130020 [details]
screenshot of columns after patch
(In reply to Lucas Gass from comment #4) > Created attachment 130020 [details] > screenshot of columns after patch Yeah, that is not how it was supposed to look... What page is that on? I thought I fixed that. (In reply to Magnus Enger from comment #5) > (In reply to Lucas Gass from comment #4) > > Created attachment 130020 [details] > > screenshot of columns after patch > > Yeah, that is not how it was supposed to look... What page is that on? I > thought I fixed that. Magnus, it looks like that for me on both pages: http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=5 http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=5 > Magnus, it looks like that for me on both pages: > > http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=5 > http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=5 Looks OK when I test... From your screenshot, it looks like the header row is created ok, but then the cells in the column below it are not created, resulting in cells not being under their proper headings. Those cells are created from JavaScript. Did you make a hard reload (Ctrl+Shift+R)? Could you verify you have this code in http://localhost:8081/intranet-tmpl/prog/js/holds_21.1200011.js: { "mDataProp": function( oObj ) { return oObj.itemtype_descr && oObj.itemtype_descr.escapeHtml() || ""; } }, Thanks for testing! OK, my apologies Magnus. As soon as I cleared my cache everything looks fine. It must have been the JS. The only thing now is the QA tool would git you to rename your commit message: "Bug 29982 - Show itemtype in holds table on patron details" * Commit title does not start with 'Bug XXXXX: ' - 55787708a3 Created attachment 130144 [details] [review] Bug 29982: Show itemtype in holds table on patron details Show item type in the holds tables on "Check out" and "Details" tabs in the intranet. To test: - Add an item level hold - Go to patron details and look at the "Check out" tab - Click on the "Holds" horizontal tab and verify the item type is shown in a column between "Title" and "Call number" - Go to the "Details" tab - Click on the "Holds" horizontal tab and verify the display is the same as above - Make a record level hold and verify the item type is not shown in the tables described above - Check in an item from the record level hold, so it is "waiting" for the patron - Verify the item type is now shown in the same way as for the item level hold, as described above Sorry, bad habit of copying from Bugzilla. Created attachment 130147 [details] [review] Bug 29982: Show itemtype in holds table on patron details Show item type in the holds tables on "Check out" and "Details" tabs in the intranet. To test: - Add an item level hold - Go to patron details and look at the "Check out" tab - Click on the "Holds" horizontal tab and verify the item type is shown in a column between "Title" and "Call number" - Go to the "Details" tab - Click on the "Holds" horizontal tab and verify the display is the same as above - Make a record level hold and verify the item type is not shown in the tables described above - Check in an item from the record level hold, so it is "waiting" for the patron - Verify the item type is now shown in the same way as for the item level hold, as described above Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> |