Bug 29984

Summary: Remove unused method Koha::Patrons->anonymise_issue_history
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: Architecture, internals, and plumbingAssignee: Tomás Cohen Arazi (tcohen) <tomascohen>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: kyle, martin.renvoize
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00
Circulation function:
Bug Depends on: 29843    
Bug Blocks:    
Attachments: Bug 29984: Remove unused method Koha::Patrons->anonymise_issue_history
Bug 29984: Remove unused method Koha::Patrons->anonymise_issue_history
Bug 29984: Remove unused method Koha::Patrons->anonymise_issue_history

Description Tomás Cohen Arazi (tcohen) 2022-01-31 19:40:47 UTC
As of bug 29843, this method is no longer used:

$ git grep anonymise_issue_history
=> FAIL: Unused but still there.
Comment 1 Tomás Cohen Arazi (tcohen) 2022-02-04 19:08:56 UTC
Created attachment 130173 [details] [review]
Bug 29984: Remove unused method Koha::Patrons->anonymise_issue_history

The method is no longer used, and replaced by
Koha::Old::Checkouts->anonymize.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests still pass
3. Run:
   $ git grep anonymise_issue_history
=> SUCCESS: The code doesn't mention it
4. Sign off :-D
Comment 2 David Nind 2022-02-04 19:25:38 UTC
Created attachment 130174 [details] [review]
Bug 29984: Remove unused method Koha::Patrons->anonymise_issue_history

The method is no longer used, and replaced by
Koha::Old::Checkouts->anonymize.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests still pass
3. Run:
   $ git grep anonymise_issue_history
=> SUCCESS: The code doesn't mention it
4. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize (ashimema) 2022-02-08 09:52:38 UTC
Created attachment 130275 [details] [review]
Bug 29984: Remove unused method Koha::Patrons->anonymise_issue_history

The method is no longer used, and replaced by
Koha::Old::Checkouts->anonymize.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests still pass
3. Run:
   $ git grep anonymise_issue_history
=> SUCCESS: The code doesn't mention it
4. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2022-02-08 09:53:10 UTC
As described.. passing QA
Comment 5 Fridolin Somers 2022-02-11 00:38:22 UTC
Pushed to master for 22.05, thanks to everybody involved ﷐[U+1F984]﷑