Bug 29984 - Remove unused method Koha::Patrons->anonymise_issue_history
Summary: Remove unused method Koha::Patrons->anonymise_issue_history
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Testopia
URL:
Keywords:
Depends on: 29843
Blocks:
  Show dependency tree / graph
 
Reported: 2022-01-31 19:40 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2022-12-12 21:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00
Circulation function:

Attachments
Bug 29984: Remove unused method Koha::Patrons->anonymise_issue_history (6.98 KB, patch)
2022-02-04 19:08 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 29984: Remove unused method Koha::Patrons->anonymise_issue_history (7.03 KB, patch)
2022-02-04 19:25 UTC, David Nind 		Details | Diff | Splinter Review
Bug 29984: Remove unused method Koha::Patrons->anonymise_issue_history (7.09 KB, patch)
2022-02-08 09:52 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2022-01-31 19:40:47 UTC 
As of bug 29843, this method is no longer used:

$ git grep anonymise_issue_history
=> FAIL: Unused but still there.
Comment 1 Tomás Cohen Arazi (tcohen) 2022-02-04 19:08:56 UTC 
Created attachment 130173 [details] [review]
Bug 29984: Remove unused method Koha::Patrons->anonymise_issue_history

The method is no longer used, and replaced by
Koha::Old::Checkouts->anonymize.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests still pass
3. Run:
   $ git grep anonymise_issue_history
=> SUCCESS: The code doesn't mention it
4. Sign off :-D
Comment 2 David Nind 2022-02-04 19:25:38 UTC 
Created attachment 130174 [details] [review]
Bug 29984: Remove unused method Koha::Patrons->anonymise_issue_history

The method is no longer used, and replaced by
Koha::Old::Checkouts->anonymize.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests still pass
3. Run:
   $ git grep anonymise_issue_history
=> SUCCESS: The code doesn't mention it
4. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize (ashimema) 2022-02-08 09:52:38 UTC 
Created attachment 130275 [details] [review]
Bug 29984: Remove unused method Koha::Patrons->anonymise_issue_history

The method is no longer used, and replaced by
Koha::Old::Checkouts->anonymize.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests still pass
3. Run:
   $ git grep anonymise_issue_history
=> SUCCESS: The code doesn't mention it
4. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2022-02-08 09:53:10 UTC 
As described.. passing QA
Comment 5 Fridolin Somers 2022-02-11 00:38:22 UTC 
Pushed to master for 22.05, thanks to everybody involved ﷐[U+1F984]﷑