|
Description
Aleisha Amohia
2022-02-01 02:20:39 UTC
Created attachment 130034 [details] [review] Bug 29990: Add ShowHeadingUse system preference Created attachment 130035 [details] [review] Bug 29990: Show authority appropriate heading use on search results Authority heading use is based on authority MARC 008/14-16. This could be useful to show on authority search results, if new system preference ShowHeadingUse is enabled. To test: 1. Apply patches, update database, restart services 2. Go to Koha Administration -> system preferences -> searching tab. Notice new ShowHeadingUse system preference is disabled. Leave it disabled for now. 3. Do an authority search. Confirm it works as expected and no new information is shown since ShowHeadingUse is disabled. 4. Do a biblio search and edit a record. Go to one of the authority fields (1xx, 6xx or 7xx) and launch the authority finder plugin. Do an authority search and confirm it works as expected and no new information is shown since ShowHeadingUse is disabled. 5. Go back to system preferences and enable ShowHeadingUse syspref. 6. Repeat steps 3 and 4 but confirm the 'Heading use' column now shows, and correctly displays what the heading can be used for based on 008/14-16. Sponsored-by: Education Services Australia SCIS Does not apply. Merge conflict: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29990: Add ShowHeadingUse system preference Applying: Bug 29990: Show authority appropriate heading use on search results Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt M koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 29990: Show authority appropriate heading use on search results Created attachment 131583 [details] [review] Bug 29990: Show authority appropriate heading use on search results Authority heading use is based on authority MARC 008/14-16. This could be useful to show on authority search results, if new system preference ShowHeadingUse is enabled. To test: 1. Apply patches, update database, restart services 2. Go to Koha Administration -> system preferences -> searching tab. Notice new ShowHeadingUse system preference is disabled. Leave it disabled for now. 3. Do an authority search. Confirm it works as expected and no new information is shown since ShowHeadingUse is disabled. 4. Do a biblio search and edit a record. Go to one of the authority fields (1xx, 6xx or 7xx) and launch the authority finder plugin. Do an authority search and confirm it works as expected and no new information is shown since ShowHeadingUse is disabled. 5. Go back to system preferences and enable ShowHeadingUse syspref. 6. Repeat steps 3 and 4 but confirm the 'Heading use' column now shows, and correctly displays what the heading can be used for based on 008/14-16. Sponsored-by: Education Services Australia SCIS Created attachment 131617 [details] [review] Bug 29990: Show authority appropriate heading use on search results Authority heading use is based on authority MARC 008/14-16. This could be useful to show on authority search results, if new system preference ShowHeadingUse is enabled. To test: 1. Apply patches, update database, restart services 2. Go to Koha Administration -> system preferences -> searching tab. Notice new ShowHeadingUse system preference is disabled. Leave it disabled for now. 3. Do an authority search. Confirm it works as expected and no new information is shown since ShowHeadingUse is disabled. 4. Do a biblio search and edit a record. Go to one of the authority fields (1xx, 6xx or 7xx) and launch the authority finder plugin. Do an authority search and confirm it works as expected and no new information is shown since ShowHeadingUse is disabled. 5. Go back to system preferences and enable ShowHeadingUse syspref. 6. Repeat steps 3 and 4 but confirm the 'Heading use' column now shows, and correctly displays what the heading can be used for based on 008/14-16. Sponsored-by: Education Services Australia SCIS Signed-off-by: Jessica <jzairo@bywatersolutions.com> Works as Explained- signed off. *** Bug 26079 has been marked as a duplicate of this bug. *** Created attachment 132606 [details] [review] Bug 29990: Add ShowHeadingUse system preference Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 132607 [details] [review] Bug 29990: Show authority appropriate heading use on search results Authority heading use is based on authority MARC 008/14-16. This could be useful to show on authority search results, if new system preference ShowHeadingUse is enabled. To test: 1. Apply patches, update database, restart services 2. Go to Koha Administration -> system preferences -> searching tab. Notice new ShowHeadingUse system preference is disabled. Leave it disabled for now. 3. Do an authority search. Confirm it works as expected and no new information is shown since ShowHeadingUse is disabled. 4. Do a biblio search and edit a record. Go to one of the authority fields (1xx, 6xx or 7xx) and launch the authority finder plugin. Do an authority search and confirm it works as expected and no new information is shown since ShowHeadingUse is disabled. 5. Go back to system preferences and enable ShowHeadingUse syspref. 6. Repeat steps 3 and 4 but confirm the 'Heading use' column now shows, and correctly displays what the heading can be used for based on 008/14-16. Sponsored-by: Education Services Australia SCIS Signed-off-by: Jessica <jzairo@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 132608 [details] [review] Bug 29990: (QA follow-up) Change class name and apply to heading, add -x to update Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 22.05, thanks to everybody involved [U+1F984] Master broken due to "Add ShowHeadingUse system preference" Missing closing parenthesis. Created attachment 133128 [details] [review] Bug 29990: (follow-up) add missing parenthesis Lucas also added the fix in bug 30501.. I QA'd is there to make sure it doesn't get held up in any way.. Comment on attachment 133128 [details] [review] Bug 29990: (follow-up) add missing parenthesis Fixed by Bug 30501 |