| Summary: | OPAC advanced search page broken by Bug 29844 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 29844 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 30101: Fix OPAC advanced search after Bug 29844
Bug 30101: Fix OPAC advanced search after Bug 29844 Bug 30101: Fix OPAC advanced search after Bug 29844 |
||
Created attachment 130570 [details] [review] Bug 30101: Fix OPAC advanced search after Bug 29844 Bug 29844 forgot to add as_list to opac-search.pl. You can see it changed search.pl Patch fixes and also adds explicit interface = opac in get_search_groups() call. Since intranet is explicit, opac should also be. We keep opac as default value. Test plan : 1) Create a libary group for OPAC and one for staff 2) Go to OPAC advanced search page 3) Check you see the OPAC libary group *** Bug 30091 has been marked as a duplicate of this bug. *** Created attachment 130572 [details] [review] Bug 30101: Fix OPAC advanced search after Bug 29844 Bug 29844 forgot to add as_list to opac-search.pl. You can see it changed search.pl Patch fixes and also adds explicit interface = opac in get_search_groups() call. Since intranet is explicit, opac should also be. We keep opac as default value. Test plan : 1) Create a libary group for OPAC and one for staff 2) Go to OPAC advanced search page 3) Check you see the OPAC libary group Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 130590 [details] [review] Bug 30101: Fix OPAC advanced search after Bug 29844 Bug 29844 forgot to add as_list to opac-search.pl. You can see it changed search.pl Patch fixes and also adds explicit interface = opac in get_search_groups() call. Since intranet is explicit, opac should also be. We keep opac as default value. Test plan : 1) Create a libary group for OPAC and one for staff 2) Go to OPAC advanced search page 3) Check you see the OPAC libary group Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.05, thanks to everybody involved [U+1F984] |
Template process failed: undef error - The method Koha::Library::Groups->id is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Objects.pm line 572 Koha::Objects::AUTOLOAD('Koha::Library::Groups=HASH(0x5576ff179cc8)') called at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 253