Bug 30104

Summary: Holds to pull is broken
Product: Koha Reporter: Lucas Gass <lucas>
Component: CirculationAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Tomás Cohen Arazi <tomascohen>
Severity: major    
Priority: P5 - low CC: gmcharlt, jonathan.druart, kyle.m.hall, kyle, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00
Bug Depends on: 29844    
Bug Blocks:    
Attachments: Bug 30104: (bug 29844 follow-up): Fix holds to pull
Bug 30104: (bug 29844 follow-up): Fix holds to pull
Bug 30104: (bug 29844 follow-up): Fix holds to pull

Description Lucas Gass 2022-02-14 23:13:43 UTC
TO recreate:

Go to Holds to Pull and see this error:

The method Koha::Items->biblionumber is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Objects.pm line 572
Comment 1 Lucas Gass 2022-02-14 23:15:11 UTC
Maybe this is also caused by Bug 29844?
Comment 2 Jonathan Druart 2022-02-15 07:47:11 UTC
Created attachment 130593 [details] [review]
Bug 30104: (bug 29844 follow-up): Fix holds to pull

There was an error when circ/pendingreserves.pl was hit:
The method Koha::Items->biblionumber is not covered by tests!
Comment 3 Lucas Gass 2022-02-15 14:57:24 UTC
Created attachment 130620 [details] [review]
Bug 30104: (bug 29844 follow-up): Fix holds to pull

There was an error when circ/pendingreserves.pl was hit:
The method Koha::Items->biblionumber is not covered by tests!

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2022-02-16 11:22:50 UTC
Created attachment 130660 [details] [review]
Bug 30104: (bug 29844 follow-up): Fix holds to pull

There was an error when circ/pendingreserves.pl was hit:
The method Koha::Items->biblionumber is not covered by tests!

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Fridolin Somers 2022-02-17 07:53:01 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄