| Summary: | We shouldn't calculate get_items_that_can_fill when we don't have any holds | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Circulation | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, gmcharlt, kyle, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.05
|
|
| Circulation function: | |||
| Attachments: |
Bug 30155: Don't get items that can fillholds if there are no holds
Bug 30155: Don't get items that can fillholds if there are no holds Bug 30155: Don't get items that can fillholds if there are no holds |
||
|
Description
Nick Clemens (kidclamp)
2022-02-22 16:53:07 UTC
Created attachment 131024 [details] [review] Bug 30155: Don't get items that can fillholds if there are no holds This makes two changes: 1 - We no longer call get_items_that_can_fill if there are no holds 2 - The subroutine will return an empty Koha::Items object if there are no holds passed To test: - apply patch, restart services - prove t/db_dependent/Koha/Holds.t - it passes! Created attachment 131485 [details] [review] Bug 30155: Don't get items that can fillholds if there are no holds This makes two changes: 1 - We no longer call get_items_that_can_fill if there are no holds 2 - The subroutine will return an empty Koha::Items object if there are no holds passed Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 131524 [details] [review] Bug 30155: Don't get items that can fillholds if there are no holds This makes two changes: 1 - We no longer call get_items_that_can_fill if there are no holds 2 - The subroutine will return an empty Koha::Items object if there are no holds passed Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.05 |