| Summary: | Add subtitle to serial subscription search | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Serials | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, kyle, martin.renvoize, shi-yao.wang, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30441 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
Adds the biblio.subtitle to the 'Title' column on serial-search.pl.
|
Version(s) released in: |
22.05.00,21.11.07
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 30302, 30466 | ||
| Attachments: |
Bug 30204: Add subtitle to serial search results
Bug 30204: Add subtitle to serial search results Bug 30204: Add subtitle to serial search results Bug 30204: Add unit test Bug 30204: Add unit test Bug 30204: Add unit test Bug 30204: Add subtitle to serial search results |
||
|
Description
Lucas Gass (lukeg)
2022-03-01 16:09:02 UTC
Created attachment 131198 [details] [review] Bug 30204: Add subtitle to serial search results To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Notice the subtitle doesn't appear. 4. Apply patch and restart_all 5. Again try step 2. 6. Notice the subtitle appears alongside the title now. 7. Make sure it still sorts that column correctly. Created attachment 131560 [details] [review] Bug 30204: Add subtitle to serial search results To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Notice the subtitle doesn't appear. 4. Apply patch and restart_all 5. Again try step 2. 6. Notice the subtitle appears alongside the title now. 7. Make sure it still sorts that column correctly. Signed-off-by: shiyao <shiyao@inlibro.com> Created attachment 132907 [details] [review] Bug 30204: Add subtitle to serial search results To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Notice the subtitle doesn't appear. 4. Apply patch and restart_all 5. Again try step 2. 6. Notice the subtitle appears alongside the title now. 7. Make sure it still sorts that column correctly. Signed-off-by: shiyao <shiyao@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> This works great! But as the patches include a change to SearchSubscriptions in Serials.pm, we should probably have a small addition to the unit tests. Created attachment 132979 [details] [review] Bug 30204: Add unit test Created attachment 132981 [details] [review] Bug 30204: Add unit test Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 133201 [details] [review] Bug 30204: Add unit test Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Created attachment 133202 [details] [review] Bug 30204: Add subtitle to serial search results To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Notice the subtitle doesn't appear. 4. Apply patch and restart_all 5. Again try step 2. 6. Notice the subtitle appears alongside the title now. 7. Make sure it still sorts that column correctly. Signed-off-by: shiyao <shiyao@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works, qa script happy, code looks good, passing QA :) Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.07! Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. |