On serials-search.pl when one does a serial search the results will display the title of the connected biblio but it will not display the biblio.subtitle, it would be handy if it did show the subtitle along with the title.
Created attachment 131198 [details] [review] Bug 30204: Add subtitle to serial search results To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Notice the subtitle doesn't appear. 4. Apply patch and restart_all 5. Again try step 2. 6. Notice the subtitle appears alongside the title now. 7. Make sure it still sorts that column correctly.
Created attachment 131560 [details] [review] Bug 30204: Add subtitle to serial search results To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Notice the subtitle doesn't appear. 4. Apply patch and restart_all 5. Again try step 2. 6. Notice the subtitle appears alongside the title now. 7. Make sure it still sorts that column correctly. Signed-off-by: shiyao <shiyao@inlibro.com>
Created attachment 132907 [details] [review] Bug 30204: Add subtitle to serial search results To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Notice the subtitle doesn't appear. 4. Apply patch and restart_all 5. Again try step 2. 6. Notice the subtitle appears alongside the title now. 7. Make sure it still sorts that column correctly. Signed-off-by: shiyao <shiyao@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This works great! But as the patches include a change to SearchSubscriptions in Serials.pm, we should probably have a small addition to the unit tests.
Created attachment 132979 [details] [review] Bug 30204: Add unit test
Created attachment 132981 [details] [review] Bug 30204: Add unit test Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 133201 [details] [review] Bug 30204: Add unit test Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 133202 [details] [review] Bug 30204: Add subtitle to serial search results To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Notice the subtitle doesn't appear. 4. Apply patch and restart_all 5. Again try step 2. 6. Notice the subtitle appears alongside the title now. 7. Make sure it still sorts that column correctly. Signed-off-by: shiyao <shiyao@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, qa script happy, code looks good, passing QA :)
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.07!
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.