| Summary: | Add biblio.subtitle to the subscription-detail.pl page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Serials | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, dcook, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
Add the biblio.subtitle to the serial subscription details page.
|
Version(s) released in: |
22.05.00,21.11.06
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 30302, 34199 | ||
| Attachments: |
Bug 30205: Add subtitle to subscription detail page
Bug 30205: Add subtitle to subscription detail page Bug 30205: Add subtitle to subscription detail page |
||
|
Description
Lucas Gass (lukeg)
2022-03-01 16:29:08 UTC
Created attachment 131201 [details] [review] Bug 30205: Add subtitle to subscription detail page To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Click on one of those subscription to be taken to the subscription detail page. 4. Look at the main heading (h1) and the "Biblio:" line. Notice there is no subtitle in either place 5. Apply patch, restart_all, and reload the subscription detail page. 6. You should now see the subtitle on both the main heading (h1) and on the 'Biblio:' line. Did you look at including biblio-title.inc? Maybe it's overkill here? (In reply to Owen Leonard from comment #2) > Did you look at including biblio-title.inc? Maybe it's overkill here? I did not, but now I will! *** Bug 23499 has been marked as a duplicate of this bug. *** Created attachment 131762 [details] [review] Bug 30205: Add subtitle to subscription detail page To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Click on one of those subscription to be taken to the subscription detail page. 4. Look at the main heading (h1) and the "Biblio:" line. Notice there is no subtitle in either place 5. Apply patch, restart_all, and reload the subscription detail page. 6. You should now see the subtitle on both the main heading (h1) and on the 'Biblio:' line. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 132915 [details] [review] Bug 30205: Add subtitle to subscription detail page To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Click on one of those subscription to be taken to the subscription detail page. 4. Look at the main heading (h1) and the "Biblio:" line. Notice there is no subtitle in either place 5. Apply patch, restart_all, and reload the subscription detail page. 6. You should now see the subtitle on both the main heading (h1) and on the 'Biblio:' line. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Lucas Gass from comment #3) > (In reply to Owen Leonard from comment #2) > > Did you look at including biblio-title.inc? Maybe it's overkill here? > > I did not, but now I will! Hi Andrew, I am ok with the patch as is, but maybe you can add a note why not biblio-title.inc? Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.06 |