Bug 30205 - Add biblio.subtitle to the subscription-detail.pl page
Summary: Add biblio.subtitle to the subscription-detail.pl page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
: 23499 (view as bug list)
Depends on:
Blocks: 30302 34199
  Show dependency treegraph
 
Reported: 2022-03-01 16:29 UTC by Lucas Gass
Modified: 2023-07-05 07:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Add the biblio.subtitle to the serial subscription details page.
Version(s) released in:
22.05.00,21.11.06


Attachments
Bug 30205: Add subtitle to subscription detail page (3.39 KB, patch)
2022-03-01 16:32 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 30205: Add subtitle to subscription detail page (3.45 KB, patch)
2022-03-15 20:20 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 30205: Add subtitle to subscription detail page (3.56 KB, patch)
2022-04-03 10:47 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2022-03-01 16:29:08 UTC
On the subscription-detail page we show the biblio.title, we should also show the biblio.subtitle, if it exists. 

This can be shown both in the h1 heading and on the 'Biblio:' line.
Comment 1 Lucas Gass 2022-03-01 16:32:53 UTC
Created attachment 131201 [details] [review]
Bug 30205: Add subtitle to subscription detail page

To test:
1. Make some new serial subscriptions and connect them to biblios that contain subtitles.
2. Do a serial search that will return your newly created subscription.
3. Click on one of those subscription to be taken to the subscription detail page.
4. Look at the main heading (h1) and the "Biblio:" line. Notice there is no subtitle in either place
5. Apply patch, restart_all, and reload the subscription detail page.
6. You should now see the subtitle on both the main heading (h1) and on the 'Biblio:' line.
Comment 2 Owen Leonard 2022-03-03 15:21:33 UTC
Did you look at including biblio-title.inc? Maybe it's overkill here?
Comment 3 Lucas Gass 2022-03-03 17:52:11 UTC
(In reply to Owen Leonard from comment #2)
> Did you look at including biblio-title.inc? Maybe it's overkill here?

I did not, but now I will!
Comment 4 Andrew Fuerste-Henry 2022-03-15 20:02:57 UTC
*** Bug 23499 has been marked as a duplicate of this bug. ***
Comment 5 Andrew Fuerste-Henry 2022-03-15 20:20:57 UTC
Created attachment 131762 [details] [review]
Bug 30205: Add subtitle to subscription detail page

To test:
1. Make some new serial subscriptions and connect them to biblios that contain subtitles.
2. Do a serial search that will return your newly created subscription.
3. Click on one of those subscription to be taken to the subscription detail page.
4. Look at the main heading (h1) and the "Biblio:" line. Notice there is no subtitle in either place
5. Apply patch, restart_all, and reload the subscription detail page.
6. You should now see the subtitle on both the main heading (h1) and on the 'Biblio:' line.

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 6 Katrin Fischer 2022-04-03 10:47:38 UTC
Created attachment 132915 [details] [review]
Bug 30205: Add subtitle to subscription detail page

To test:
1. Make some new serial subscriptions and connect them to biblios that contain subtitles.
2. Do a serial search that will return your newly created subscription.
3. Click on one of those subscription to be taken to the subscription detail page.
4. Look at the main heading (h1) and the "Biblio:" line. Notice there is no subtitle in either place
5. Apply patch, restart_all, and reload the subscription detail page.
6. You should now see the subtitle on both the main heading (h1) and on the 'Biblio:' line.

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2022-04-03 10:48:52 UTC
(In reply to Lucas Gass from comment #3)
> (In reply to Owen Leonard from comment #2)
> > Did you look at including biblio-title.inc? Maybe it's overkill here?
> 
> I did not, but now I will!

Hi Andrew, I am ok with the patch as is, but maybe you can add a note why not biblio-title.inc?
Comment 8 Fridolin Somers 2022-04-21 06:44:12 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄
Comment 9 Kyle M Hall 2022-04-29 17:19:22 UTC
Pushed to 21.11.x for 21.11.06