Summary: | Hide Delete (aka Priority) column when user only has place_hold permission | ||
---|---|---|---|
Product: | Koha | Reporter: | Sara Brown <sbrown> |
Component: | Hold requests | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, cbrannon, gmcharlt, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29540 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Bug Depends on: | 30207 | ||
Bug Blocks: | |||
Attachments: |
Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission
Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission |
Description
Sara Brown
2022-03-02 14:57:12 UTC
Created attachment 131327 [details] [review] Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission This patch changes the way the priority column displays when viewing a list of holds as a user who doesn't have permission to change hold priority. To test: - Apply the patch and log into the staff interface as a user with at least "place_hold" permission. - Locate a record which can be put on hold and place multiple holds. - View the list of holds. - As a user with both "place_hold" and "modify_holds_priority" permission, you should see a "Priority" column with <select> fields allowing you to change hold priority. You should also see the arrow buttons for changing priority. - As a user with only "place_hold" permission, the "Priority" column should show the priority as a number. You should not see the arrow buttons. - In both cases, confirm that all operations work correctly: Changing hold date, expiration date, pickup library, suspended status; Cancelling holds. Created attachment 131336 [details] [review] Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission This patch changes the way the priority column displays when viewing a list of holds as a user who doesn't have permission to change hold priority. To test: - Apply the patch and log into the staff interface as a user with at least "place_hold" permission. - Locate a record which can be put on hold and place multiple holds. - View the list of holds. - As a user with both "place_hold" and "modify_holds_priority" permission, you should see a "Priority" column with <select> fields allowing you to change hold priority. You should also see the arrow buttons for changing priority. - As a user with only "place_hold" permission, the "Priority" column should show the priority as a number. You should not see the arrow buttons. - In both cases, confirm that all operations work correctly: Changing hold date, expiration date, pickup library, suspended status; Cancelling holds. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Works as described. Created attachment 138761 [details] [review] Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission This patch changes the way the priority column displays when viewing a list of holds as a user who doesn't have permission to change hold priority. To test: - Apply the patch and log into the staff interface as a user with at least "place_hold" permission. - Locate a record which can be put on hold and place multiple holds. - View the list of holds. - As a user with both "place_hold" and "modify_holds_priority" permission, you should see a "Priority" column with <select> fields allowing you to change hold priority. You should also see the arrow buttons for changing priority. - As a user with only "place_hold" permission, the "Priority" column should show the priority as a number. You should not see the arrow buttons. - In both cases, confirm that all operations work correctly: Changing hold date, expiration date, pickup library, suspended status; Cancelling holds. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! |