With the change to holds permissions in Bug 29540, the Delete (or Priority, with full holds permissions) column isn't useful and is misleading for users with only the place_hold permission. They don't have the option to change holds' priority using the column, and if they select 'del' on a patron to delete their hold, they get locked out for having insufficient permissions when they click the Update Hold(s) button. But this is misleading because they *can* delete an individual hold using the red X. It would be clearer if that entire column were hidden for users with only the place_hold permission.
Created attachment 131327 [details] [review] Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission This patch changes the way the priority column displays when viewing a list of holds as a user who doesn't have permission to change hold priority. To test: - Apply the patch and log into the staff interface as a user with at least "place_hold" permission. - Locate a record which can be put on hold and place multiple holds. - View the list of holds. - As a user with both "place_hold" and "modify_holds_priority" permission, you should see a "Priority" column with <select> fields allowing you to change hold priority. You should also see the arrow buttons for changing priority. - As a user with only "place_hold" permission, the "Priority" column should show the priority as a number. You should not see the arrow buttons. - In both cases, confirm that all operations work correctly: Changing hold date, expiration date, pickup library, suspended status; Cancelling holds.
Created attachment 131336 [details] [review] Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission This patch changes the way the priority column displays when viewing a list of holds as a user who doesn't have permission to change hold priority. To test: - Apply the patch and log into the staff interface as a user with at least "place_hold" permission. - Locate a record which can be put on hold and place multiple holds. - View the list of holds. - As a user with both "place_hold" and "modify_holds_priority" permission, you should see a "Priority" column with <select> fields allowing you to change hold priority. You should also see the arrow buttons for changing priority. - As a user with only "place_hold" permission, the "Priority" column should show the priority as a number. You should not see the arrow buttons. - In both cases, confirm that all operations work correctly: Changing hold date, expiration date, pickup library, suspended status; Cancelling holds. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Works as described.
Created attachment 138761 [details] [review] Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission This patch changes the way the priority column displays when viewing a list of holds as a user who doesn't have permission to change hold priority. To test: - Apply the patch and log into the staff interface as a user with at least "place_hold" permission. - Locate a record which can be put on hold and place multiple holds. - View the list of holds. - As a user with both "place_hold" and "modify_holds_priority" permission, you should see a "Priority" column with <select> fields allowing you to change hold priority. You should also see the arrow buttons for changing priority. - As a user with only "place_hold" permission, the "Priority" column should show the priority as a number. You should not see the arrow buttons. - In both cases, confirm that all operations work correctly: Changing hold date, expiration date, pickup library, suspended status; Cancelling holds. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!