Bug 30255

Created attachment 131527 [details] [review]
Bug 30255: Make selection step optional for batch record del/mod

Allow the user to optionally skip the record selection step in
batch record deletion/modification tools and directly enqueue job for
all records.

1) Create a record modification template.
2) Enter some biblionumber(s) in the batch record modification tool form,
   select the record modification template, the "Select records to modify"
   option and proceed to the next step.
3) Verify that records can be selected, proceed to the next step and
   verify that a job has been enqueued for the selected records.
4) Return to the batch record modification form and enter the biblionumbers(s)
   again. Now select "Modify all" and proceed to the next step.
5) Verify that a job has been enqueued for all records.
6) Enter some biblionumber(s) in the batch record deletion tool form,
   select the "Select records to delete" option and proceed to the
   next step.
7) Verify that records can be selected, proceed to the next step and
   verify that a job has been enqueued for the selected records.
8) Return to the batch record deletion form and enter the biblionumbers(s)
   again. Now select "Delete all" and proceed to the next step.
9) Verify that a job has been enqueued for all records.

Sponsored by: Gothenburg University Library

Hi David, please set yourself as Assignee, when you start working on a patch for a bug, thx!

Created attachment 151289 [details] [review]
Bug 30255: Make selection step optional for batch record del/mod

Allow the user to optionally skip the record selection step in
batch record deletion/modification tools and directly enqueue job for
all records.

1) Create a record modification template.
2) Enter some biblionumber(s) in the batch record modification tool form,
   select the record modification template, the "Select records to modify"
   option and proceed to the next step.
3) Verify that records can be selected, proceed to the next step and
   verify that a job has been enqueued for the selected records.
4) Return to the batch record modification form and enter the biblionumbers(s)
   again. Now select "Modify all" and proceed to the next step.
5) Verify that a job has been enqueued for all records.
6) Enter some biblionumber(s) in the batch record deletion tool form,
   select the "Select records to delete" option and proceed to the
   next step.
7) Verify that records can be selected, proceed to the next step and
   verify that a job has been enqueued for the selected records.
8) Return to the batch record deletion form and enter the biblionumbers(s)
   again. Now select "Delete all" and proceed to the next step.
9) Verify that a job has been enqueued for all records.

Sponsored by: Gothenburg University Library

Rebased against master. Can't get my local koha docker to work with latest master though, and considering how many issues encountered will probably take a while to fix, so have not been able to test.

(In reply to David Gustafsson from comment #4)
> Rebased against master. Can't get my local koha docker to work with latest
> master though, and considering how many issues encountered will probably
> take a while to fix, so have not been able to test.

It was broken this "morning", pull the new images it should be fixed now.

Created attachment 151382 [details] [review]
Bug 30255: Make selection step optional for batch record del/mod

Allow the user to optionally skip the record selection step in
batch record deletion/modification tools and directly enqueue job for
all records.

1) Create a record modification template.
2) Enter some biblionumber(s) in the batch record modification tool form,
   select the record modification template, the "Select records to modify"
   option and proceed to the next step.
3) Verify that records can be selected, proceed to the next step and
   verify that a job has been enqueued for the selected records.
4) Return to the batch record modification form and enter the biblionumbers(s)
   again. Now select "Modify all" and proceed to the next step.
5) Verify that a job has been enqueued for all records.
6) Enter some biblionumber(s) in the batch record deletion tool form,
   select the "Select records to delete" option and proceed to the
   next step.
7) Verify that records can be selected, proceed to the next step and
   verify that a job has been enqueued for the selected records.
8) Return to the batch record deletion form and enter the biblionumbers(s)
   again. Now select "Delete all" and proceed to the next step.
9) Verify that a job has been enqueued for all records.

Sponsored by: Gothenburg University Library

Signed-off-by: Laura <laura.escamilla@bywatersolutions.com>

I have the feeling that it is too easy to click select all and continue.
Especially since we are used to arrive at the next selection form.
So I would suggest to add at least a confirm box (in js or so) to make sure that someone knows that he is going to do something affecting the whole db.
If you do not agree, please explain why this would not be needed at all :)

Changing status for feedback.

Created attachment 162547 [details] [review]
Bug 30255: Show hint there will be no confirmation when selecting "Modify all"

Thanks for the feedback, the used will now be notified that there is no confirmation step when selecting "Modify all".

For some reason the initial state is "Modify all" even though "Select records to modify" when loading page. Don't have time too look into right now, but will fix tomorrow.

Created attachment 162603 [details] [review]
Bug 30255: Show hint there will be no confirmation when selecting "Modify all"

Now fixed.