Bug 30255 - Allow skipping "list" step for record batch modification/deletion
Summary: Allow skipping "list" step for record batch modification/deletion
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: David Gustafsson
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-09 15:05 UTC by David Gustafsson
Modified: 2024-02-29 15:29 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 30255: Make selection step optional for batch record del/mod (15.46 KB, patch)
2022-03-09 15:36 UTC, David Gustafsson
Details | Diff | Splinter Review
Bug 30255: Make selection step optional for batch record del/mod (15.67 KB, patch)
2023-05-16 14:20 UTC, David Gustafsson
Details | Diff | Splinter Review
Bug 30255: Make selection step optional for batch record del/mod (15.72 KB, patch)
2023-05-17 20:19 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 30255: Show hint there will be no confirmation when selecting "Modify all" (2.17 KB, patch)
2024-02-28 17:55 UTC, David Gustafsson
Details | Diff | Splinter Review
Bug 30255: Show hint there will be no confirmation when selecting "Modify all" (2.19 KB, patch)
2024-02-29 15:29 UTC, David Gustafsson
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Gustafsson 2022-03-09 15:05:14 UTC
We encountered an issue using the Batch record modification/deletion-tools for a very large number of records. The "list" step where records can be optionally excluded is not relevant in our use-case and takes forever to load. This patch adds an option for skipping this step and directly enqueue the job for all specified records.
Comment 1 David Gustafsson 2022-03-09 15:36:21 UTC
Created attachment 131527 [details] [review]
Bug 30255: Make selection step optional for batch record del/mod

Allow the user to optionally skip the record selection step in
batch record deletion/modification tools and directly enqueue job for
all records.

1) Create a record modification template.
2) Enter some biblionumber(s) in the batch record modification tool form,
   select the record modification template, the "Select records to modify"
   option and proceed to the next step.
3) Verify that records can be selected, proceed to the next step and
   verify that a job has been enqueued for the selected records.
4) Return to the batch record modification form and enter the biblionumbers(s)
   again. Now select "Modify all" and proceed to the next step.
5) Verify that a job has been enqueued for all records.
6) Enter some biblionumber(s) in the batch record deletion tool form,
   select the "Select records to delete" option and proceed to the
   next step.
7) Verify that records can be selected, proceed to the next step and
   verify that a job has been enqueued for the selected records.
8) Return to the batch record deletion form and enter the biblionumbers(s)
   again. Now select "Delete all" and proceed to the next step.
9) Verify that a job has been enqueued for all records.

Sponsored by: Gothenburg University Library
Comment 2 Katrin Fischer 2022-10-01 07:59:12 UTC
Hi David, please set yourself as Assignee, when you start working on a patch for a bug, thx!
Comment 3 David Gustafsson 2023-05-16 14:20:45 UTC
Created attachment 151289 [details] [review]
Bug 30255: Make selection step optional for batch record del/mod

Allow the user to optionally skip the record selection step in
batch record deletion/modification tools and directly enqueue job for
all records.

1) Create a record modification template.
2) Enter some biblionumber(s) in the batch record modification tool form,
   select the record modification template, the "Select records to modify"
   option and proceed to the next step.
3) Verify that records can be selected, proceed to the next step and
   verify that a job has been enqueued for the selected records.
4) Return to the batch record modification form and enter the biblionumbers(s)
   again. Now select "Modify all" and proceed to the next step.
5) Verify that a job has been enqueued for all records.
6) Enter some biblionumber(s) in the batch record deletion tool form,
   select the "Select records to delete" option and proceed to the
   next step.
7) Verify that records can be selected, proceed to the next step and
   verify that a job has been enqueued for the selected records.
8) Return to the batch record deletion form and enter the biblionumbers(s)
   again. Now select "Delete all" and proceed to the next step.
9) Verify that a job has been enqueued for all records.

Sponsored by: Gothenburg University Library
Comment 4 David Gustafsson 2023-05-16 14:23:24 UTC
Rebased against master. Can't get my local koha docker to work with latest master though, and considering how many issues encountered will probably take a while to fix, so have not been able to test.
Comment 5 Jonathan Druart 2023-05-16 14:32:15 UTC
(In reply to David Gustafsson from comment #4)
> Rebased against master. Can't get my local koha docker to work with latest
> master though, and considering how many issues encountered will probably
> take a while to fix, so have not been able to test.

It was broken this "morning", pull the new images it should be fixed now.
Comment 6 ByWater Sandboxes 2023-05-17 20:19:34 UTC
Created attachment 151382 [details] [review]
Bug 30255: Make selection step optional for batch record del/mod

Allow the user to optionally skip the record selection step in
batch record deletion/modification tools and directly enqueue job for
all records.

1) Create a record modification template.
2) Enter some biblionumber(s) in the batch record modification tool form,
   select the record modification template, the "Select records to modify"
   option and proceed to the next step.
3) Verify that records can be selected, proceed to the next step and
   verify that a job has been enqueued for the selected records.
4) Return to the batch record modification form and enter the biblionumbers(s)
   again. Now select "Modify all" and proceed to the next step.
5) Verify that a job has been enqueued for all records.
6) Enter some biblionumber(s) in the batch record deletion tool form,
   select the "Select records to delete" option and proceed to the
   next step.
7) Verify that records can be selected, proceed to the next step and
   verify that a job has been enqueued for the selected records.
8) Return to the batch record deletion form and enter the biblionumbers(s)
   again. Now select "Delete all" and proceed to the next step.
9) Verify that a job has been enqueued for all records.

Sponsored by: Gothenburg University Library

Signed-off-by: Laura <laura.escamilla@bywatersolutions.com>
Comment 7 Marcel de Rooy 2023-07-21 07:42:35 UTC
I have the feeling that it is too easy to click select all and continue.
Especially since we are used to arrive at the next selection form.
So I would suggest to add at least a confirm box (in js or so) to make sure that someone knows that he is going to do something affecting the whole db.
If you do not agree, please explain why this would not be needed at all :)

Changing status for feedback.
Comment 8 David Gustafsson 2024-02-28 17:55:04 UTC
Created attachment 162547 [details] [review]
Bug 30255: Show hint there will be no confirmation when selecting "Modify all"
Comment 9 David Gustafsson 2024-02-28 17:57:08 UTC
Thanks for the feedback, the used will now be notified that there is no confirmation step when selecting "Modify all".
Comment 10 David Gustafsson 2024-02-28 18:03:22 UTC
For some reason the initial state is "Modify all" even though "Select records to modify" when loading page. Don't have time too look into right now, but will fix tomorrow.
Comment 11 David Gustafsson 2024-02-29 15:29:28 UTC
Created attachment 162603 [details] [review]
Bug 30255: Show hint there will be no confirmation when selecting "Modify all"
Comment 12 David Gustafsson 2024-02-29 15:29:55 UTC
Now fixed.