Bug 30355

Summary:	SMS auto renew digest notices are only generated if patron is also set to receive email
Product:	Koha	Reporter:	Andrew Fuerste-Henry <andrew>
Component:	Notices	Assignee:	Kyle M Hall (khall) <kyle>
Status:	RESOLVED DUPLICATE	QA Contact:	Testopia <testopia>
Severity:	major
Priority:	P5 - low	CC:	dcook, kyle, nick
Version:	Main
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:	28553
Bug Blocks:
Attachments:	Bug 28553: Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them

Description Andrew Fuerste-Henry 2022-03-24 14:53:44 UTC

To recreate:
- set AutoRenewalNotices to follow messaging prefs
- confirm your AUTO_RENEWALS_DGST letter has email and SMS content
- set up a borrower with messaging prefs to receive AUTO_RENEWALS_DGST via SMS only and an item ready for auto-renew
- set up a second borrower with messaging prefs to receive AUTO_RENEWALS_DGST via both email and SMS and an item read for auto-renew
- run the auto-renew cron
- confirm your first patron received no notice while your second patron received both email and SMS

Comment 1 Kyle M Hall (khall) 2022-07-18 16:40:22 UTC

Created attachment 137829 [details] [review]
Bug 28553: Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them

Following bug 18532, one can set a patron's messaging prefs to deliver an auto-renew notice via SMS.
However, the auto_renewals cron only knows how to generate email notices. We should not allow the selection of non-functional transport types.

Test Plan:
1) Set a patron to recieve auto-renewals via SMS, leave digest mode
   disabled. Ensure no other transports are enabled either.
2) Auto-renew some items
3) Note the SMS auto-renewal notice was generated!

Comment 2 David Cook 2022-09-13 05:57:07 UTC

I think that we can just close this one as a duplicate of bug 28553. 

Happy with that, Andrew?

Comment 3 David Cook 2022-09-13 06:44:21 UTC


*** This bug has been marked as a duplicate of bug 28553 ***

Comment 4 Andrew Fuerste-Henry 2022-09-13 13:33:06 UTC

(In reply to David Cook from comment #2)
> I think that we can just close this one as a duplicate of bug 28553. 
> 
> Happy with that, Andrew?

Good catch, thanks David!