Bug 30384

Summary: Reindent template for ordering from a MARC file
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: lucas, martin.renvoize, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on:    
Bug Blocks: 30388    
Attachments: Bug 30384: Reindent template for ordering from a MARC file
Bug 30384: (follow-up) Add markup comments
Bug 30384: Reindent template for ordering from a MARC file
Bug 30384: (follow-up) Add markup comments
Bug 30384: Reindent template for ordering from a MARC file
Bug 30384: (follow-up) Add markup comments

Description Owen Leonard 2022-03-28 14:41:35 UTC
I would like reformat the "Add orders from MARC file" template in the staff interface (addorderiso2709.tt) so that it has consistent spacing and indentation.
Comment 1 Owen Leonard 2022-03-28 16:51:13 UTC
Created attachment 132350 [details] [review]
Bug 30384: Reindent template for ordering from a MARC file

This patch updates the template for ordering from a MARC file so that
the indentation is consistent.

This patch does not fix a couple of bugs which will be fixed in a later
patch: The MARC modal window has the wrong width, and there is a
Flatpickr error in the console.

To test apply the patch and go to Acquisitions -> Vendor -> Basket ->
Add to basket -> From a staged file.

- Click "Add orders" next to the staged file you want to use.
- On the "Add orders" page, test that everything still works correctly:
- Tabs work correctly
- JavaScript controls (select all, show inactive, etc.) work
- MARC and Card previews work
- Adding orders works
Comment 2 Owen Leonard 2022-03-28 16:51:16 UTC
Created attachment 132351 [details] [review]
Bug 30384: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.
Comment 3 Chris Cormack 2022-05-05 20:28:50 UTC
Created attachment 134658 [details] [review]
Bug 30384: Reindent template for ordering from a MARC file

This patch updates the template for ordering from a MARC file so that
the indentation is consistent.

This patch does not fix a couple of bugs which will be fixed in a later
patch: The MARC modal window has the wrong width, and there is a
Flatpickr error in the console.

To test apply the patch and go to Acquisitions -> Vendor -> Basket ->
Add to basket -> From a staged file.

- Click "Add orders" next to the staged file you want to use.
- On the "Add orders" page, test that everything still works correctly:
- Tabs work correctly
- JavaScript controls (select all, show inactive, etc.) work
- MARC and Card previews work
- Adding orders works

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 4 Chris Cormack 2022-05-05 20:29:11 UTC
Created attachment 134659 [details] [review]
Bug 30384: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 5 Katrin Fischer 2022-05-06 07:45:21 UTC
Created attachment 134679 [details] [review]
Bug 30384: Reindent template for ordering from a MARC file

This patch updates the template for ordering from a MARC file so that
the indentation is consistent.

This patch does not fix a couple of bugs which will be fixed in a later
patch: The MARC modal window has the wrong width, and there is a
Flatpickr error in the console.

To test apply the patch and go to Acquisitions -> Vendor -> Basket ->
Add to basket -> From a staged file.

- Click "Add orders" next to the staged file you want to use.
- On the "Add orders" page, test that everything still works correctly:
- Tabs work correctly
- JavaScript controls (select all, show inactive, etc.) work
- MARC and Card previews work
- Adding orders works

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 6 Katrin Fischer 2022-05-06 07:45:25 UTC
Created attachment 134680 [details] [review]
Bug 30384: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 7 Katrin Fischer 2022-05-06 07:46:24 UTC
The bug fix for bug 30388 depends on this one, so maybe it could be seen as a "bug" instead of enh for this purpose.
Comment 8 Martin Renvoize 2022-05-11 07:32:32 UTC
As the bugs that depend on this aren't yet signed off I'm marking this as 22_11 candidate to delay it and shrink the queue for our RM a little at this late stage.

It'll go in very early next cycle to prevent the need for rebases.
Comment 9 Tomás Cohen Arazi 2022-06-06 16:59:48 UTC
Very early this cycle
Comment 10 Tomás Cohen Arazi 2022-06-06 17:02:46 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 11 Lucas Gass 2022-07-12 15:51:20 UTC
Patchset does not apply cleanly to 22.05.x, no backport. 

If needed please rebase.