I would like reformat the "Add orders from MARC file" template in the staff interface (addorderiso2709.tt) so that it has consistent spacing and indentation.
Created attachment 132350 [details] [review] Bug 30384: Reindent template for ordering from a MARC file This patch updates the template for ordering from a MARC file so that the indentation is consistent. This patch does not fix a couple of bugs which will be fixed in a later patch: The MARC modal window has the wrong width, and there is a Flatpickr error in the console. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that everything still works correctly: - Tabs work correctly - JavaScript controls (select all, show inactive, etc.) work - MARC and Card previews work - Adding orders works
Created attachment 132351 [details] [review] Bug 30384: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality.
Created attachment 134658 [details] [review] Bug 30384: Reindent template for ordering from a MARC file This patch updates the template for ordering from a MARC file so that the indentation is consistent. This patch does not fix a couple of bugs which will be fixed in a later patch: The MARC modal window has the wrong width, and there is a Flatpickr error in the console. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that everything still works correctly: - Tabs work correctly - JavaScript controls (select all, show inactive, etc.) work - MARC and Card previews work - Adding orders works Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 134659 [details] [review] Bug 30384: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 134679 [details] [review] Bug 30384: Reindent template for ordering from a MARC file This patch updates the template for ordering from a MARC file so that the indentation is consistent. This patch does not fix a couple of bugs which will be fixed in a later patch: The MARC modal window has the wrong width, and there is a Flatpickr error in the console. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that everything still works correctly: - Tabs work correctly - JavaScript controls (select all, show inactive, etc.) work - MARC and Card previews work - Adding orders works Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 134680 [details] [review] Bug 30384: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
The bug fix for bug 30388 depends on this one, so maybe it could be seen as a "bug" instead of enh for this purpose.
As the bugs that depend on this aren't yet signed off I'm marking this as 22_11 candidate to delay it and shrink the queue for our RM a little at this late stage. It'll go in very early next cycle to prevent the need for rebases.
Very early this cycle
Pushed to master for 22.11. Nice work everyone, thanks!
Patchset does not apply cleanly to 22.05.x, no backport. If needed please rebase.