Summary: | Reindent invoices template | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle, severine.queune |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 30400 | ||
Attachments: |
Bug 30398: Reindent invoices template
Bug 30398: (follow-up) Add markup comments Bug 30398: Reindent invoices template Bug 30398: (follow-up) Add markup comments Bug 30398: Reindent invoices template Bug 30398: (follow-up) Add markup comments |
Description
Owen Leonard
2022-03-29 16:14:02 UTC
Created attachment 132480 [details] [review] Bug 30398: Reindent invoices template This patch updates the invoices template so that the indentation is consistent. To test, apply the patch and go to Acquisitions. - Locate a vendor which has multiple invoices associated with it. - View the vendor details, and click the "Invoices" link in the sidebar. - The display of invoices should look correct. The DataTable should work correctly. - Test the search filters in the sidebar to confirm that they work too. Created attachment 132481 [details] [review] Bug 30398: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Wouldn't be useful to have a 'Clear' button next to the 'Search' one ? The form seems a little bit long : would it be possible to collapse the 'Shipment date' and 'Billing date' forms and only develop them when clicking on the title, like it's possible in the patron registration account with CollapseFieldsPatronAddForm syspref ? Maybe a silly proposal... All the other points are ok for me :) It's worth filing a separate bug if you have ideas for updating the form. The point of this patch is just to fix the format of the markup, so there should be no visible changes. Created attachment 132788 [details] [review] Bug 30398: Reindent invoices template This patch updates the invoices template so that the indentation is consistent. To test, apply the patch and go to Acquisitions. - Locate a vendor which has multiple invoices associated with it. - View the vendor details, and click the "Invoices" link in the sidebar. - The display of invoices should look correct. The DataTable should work correctly. - Test the search filters in the sidebar to confirm that they work too. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Created attachment 132789 [details] [review] Bug 30398: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Oups... Seemed I completely miss something at the first testing... Works as expected ! Thanks for the advice, I'll open new bug for the proposal :) Created attachment 132859 [details] [review] Bug 30398: Reindent invoices template This patch updates the invoices template so that the indentation is consistent. To test, apply the patch and go to Acquisitions. - Locate a vendor which has multiple invoices associated with it. - View the vendor details, and click the "Invoices" link in the sidebar. - The display of invoices should look correct. The DataTable should work correctly. - Test the search filters in the sidebar to confirm that they work too. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 132860 [details] [review] Bug 30398: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 22.05, thanks to everybody involved [U+1F984] |