Bug 30398 - Reindent invoices template
Summary: Reindent invoices template
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 30400
  Show dependency treegraph
 
Reported: 2022-03-29 16:14 UTC by Owen Leonard
Modified: 2022-12-12 21:25 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00


Attachments
Bug 30398: Reindent invoices template (47.04 KB, patch)
2022-03-29 16:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 30398: (follow-up) Add markup comments (7.60 KB, patch)
2022-03-29 16:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 30398: Reindent invoices template (47.19 KB, patch)
2022-03-31 15:00 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 30398: (follow-up) Add markup comments (7.75 KB, patch)
2022-03-31 15:00 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 30398: Reindent invoices template (47.24 KB, patch)
2022-04-01 12:41 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 30398: (follow-up) Add markup comments (7.80 KB, patch)
2022-04-01 12:41 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-03-29 16:14:02 UTC
This patch will update the invoices template so that it has consistent indentation
Comment 1 Owen Leonard 2022-03-29 16:47:40 UTC
Created attachment 132480 [details] [review]
Bug 30398: Reindent invoices template

This patch updates the invoices template so that the indentation is
consistent.

To test, apply the patch and go to Acquisitions.

- Locate a vendor which has multiple invoices associated with it.
- View the vendor details, and click the "Invoices" link in the sidebar.
- The display of invoices should look correct. The DataTable should work
  correctly.
- Test the search filters in the sidebar to confirm that they work too.
Comment 2 Owen Leonard 2022-03-29 16:47:43 UTC
Created attachment 132481 [details] [review]
Bug 30398: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.
Comment 3 Séverine Queune 2022-03-31 12:43:23 UTC
Wouldn't be useful to have a 'Clear' button next to the 'Search' one ?

The form seems a little bit long : would it be possible to collapse the 'Shipment date' and 'Billing date' forms and only develop them when clicking on the title, like it's possible in the patron registration account with  CollapseFieldsPatronAddForm syspref ? Maybe a silly proposal...

All the other points are ok for me :)
Comment 4 Owen Leonard 2022-03-31 12:54:35 UTC
It's worth filing a separate bug if you have ideas for updating the form. The point of this patch is just to fix the format of the markup, so there should be no visible changes.
Comment 5 Séverine Queune 2022-03-31 15:00:44 UTC
Created attachment 132788 [details] [review]
Bug 30398: Reindent invoices template

This patch updates the invoices template so that the indentation is
consistent.

To test, apply the patch and go to Acquisitions.

- Locate a vendor which has multiple invoices associated with it.
- View the vendor details, and click the "Invoices" link in the sidebar.
- The display of invoices should look correct. The DataTable should work
  correctly.
- Test the search filters in the sidebar to confirm that they work too.

Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Comment 6 Séverine Queune 2022-03-31 15:00:50 UTC
Created attachment 132789 [details] [review]
Bug 30398: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Comment 7 Séverine Queune 2022-03-31 15:02:37 UTC
Oups... Seemed I completely miss something at the first testing...
Works as expected !
Thanks for the advice, I'll open new bug for the proposal :)
Comment 8 Kyle M Hall 2022-04-01 12:41:37 UTC
Created attachment 132859 [details] [review]
Bug 30398: Reindent invoices template

This patch updates the invoices template so that the indentation is
consistent.

To test, apply the patch and go to Acquisitions.

- Locate a vendor which has multiple invoices associated with it.
- View the vendor details, and click the "Invoices" link in the sidebar.
- The display of invoices should look correct. The DataTable should work
  correctly.
- Test the search filters in the sidebar to confirm that they work too.

Signed-off-by: Séverine Queune <severine.queune@bulac.fr>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 9 Kyle M Hall 2022-04-01 12:41:48 UTC
Created attachment 132860 [details] [review]
Bug 30398: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Séverine Queune <severine.queune@bulac.fr>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Fridolin Somers 2022-04-12 09:41:55 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄