|
Description
Emmi Takkinen
2022-03-30 10:30:00 UTC
Created attachment 132554 [details] [review] Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description This can be used to instruct staff how the item should handled when it's checked in. For example items notforloan status has been changed as "Invoiced item" while item has been on loan. When it's checked in staff sees that they should put item aside for further processing. To test: 1. Apply patch and update database if needed 2. Set items notforloan status as -1 (or create new one) 3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin 4. Check item out for patron. 5. Check item in. => Description of notforloan status should be displayed. => Confirm notforloan status hasn't changed. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy I like this idea - but the patch doesn't currently apply. CONFLICT (content): Merge conflict in C4/Circulation.pm error: Failed to merge in the changes. Created attachment 138168 [details] [review] Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description This can be used to instruct staff how the item should handled when it's checked in. For example items notforloan status has been changed as "Invoiced item" while item has been on loan. When it's checked in staff sees that they should put item aside for further processing. To test: 1. Apply patch and update database if needed 2. Set items notforloan status as -1 (or create new one) 3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin 4. Check item out for patron. 5. Check item in. => Description of notforloan status should be displayed. => Confirm notforloan status hasn't changed. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy (In reply to Sally from comment #2) > I like this idea - but the patch doesn't currently apply. > > CONFLICT (content): Merge conflict in C4/Circulation.pm > error: Failed to merge in the changes. Patch rebased. Created attachment 138171 [details] [review] Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description This can be used to instruct staff how the item should handled when it's checked in. For example items notforloan status has been changed as "Invoiced item" while item has been on loan. When it's checked in staff sees that they should put item aside for further processing. To test: 1. Apply patch and update database if needed 2. Set items notforloan status as -1 (or create new one) 3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin 4. Check item out for patron. 5. Check item in. => Description of notforloan status should be displayed. => Confirm notforloan status hasn't changed. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Works as described, signing off. Thanks for the patch! The display of the not for loan status for the staff on check in will be particularly useful when we get a publisher recall. Careful Bug 25560 is also modifying this preference Created attachment 141211 [details] [review] Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description This can be used to instruct staff how the item should handled when it's checked in. For example items notforloan status has been changed as "Invoiced item" while item has been on loan. When it's checked in staff sees that they should put item aside for further processing. To test: 1. Apply patch and update database if needed 2. Set items notforloan status as -1 (or create new one) 3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin 4. Check item out for patron. 5. Check item in. => Description of notforloan status should be displayed. => Confirm notforloan status hasn't changed. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 141212 [details] [review] Bug 30407: (QA follow-up) Fix missing TT filter Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 141213 [details] [review] Bug 30407: (QA follow-up) Replace message with description Switches "not for loan message" to "not for loan description" to stay closer to the usual terminology for AV values also used when managing them. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> *ping* Pushed to master for 22.11. Nice work everyone, thanks! Created attachment 142724 [details] [review] Bug 30407: Fix sysprefs.sql syntax Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Enhancement will not be backported to 22.05.x |