Bug 30407 - Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description
Summary: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notfo...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Emmi Takkinen
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-30 10:30 UTC by Emmi Takkinen
Modified: 2022-08-13 08:37 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description (9.81 KB, patch)
2022-03-30 10:32 UTC, Emmi Takkinen
Details | Diff | Splinter Review
Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description (9.85 KB, patch)
2022-07-27 08:23 UTC, Emmi Takkinen
Details | Diff | Splinter Review
Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description (9.91 KB, patch)
2022-07-27 09:42 UTC, ByWater Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emmi Takkinen 2022-03-30 10:30:00 UTC
This can be used to instruct staff how the item should handled when it's checked in. For example items notforloan status has been changed as "Invoiced item" while item has been on loan. When it's checked in staff sees that they should put item aside for further processing.
Comment 1 Emmi Takkinen 2022-03-30 10:32:43 UTC
Created attachment 132554 [details] [review]
Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description

This can be used to instruct staff how the item should handled when
it's checked in. For example items notforloan status has been
changed as "Invoiced item" while item has been on loan. When it's
checked in staff sees that they should put item aside for further
processing.

To test:
1. Apply patch and update database if needed
2. Set items notforloan status as -1 (or create new one)
3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin
4. Check item out for patron.
5. Check item in.
=> Description of notforloan status should be displayed.
=> Confirm notforloan status hasn't changed.

Also prove t/db_dependent/Circulation/issue.t

Sponsored-by: Koha-Suomi Oy
Comment 2 Sally 2022-07-27 08:05:25 UTC
I like this idea - but the patch doesn't currently apply.

CONFLICT (content): Merge conflict in C4/Circulation.pm
error: Failed to merge in the changes.
Comment 3 Emmi Takkinen 2022-07-27 08:23:54 UTC
Created attachment 138168 [details] [review]
Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description

This can be used to instruct staff how the item should handled when
it's checked in. For example items notforloan status has been
changed as "Invoiced item" while item has been on loan. When it's
checked in staff sees that they should put item aside for further
processing.

To test:
1. Apply patch and update database if needed
2. Set items notforloan status as -1 (or create new one)
3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin
4. Check item out for patron.
5. Check item in.
=> Description of notforloan status should be displayed.
=> Confirm notforloan status hasn't changed.

Also prove t/db_dependent/Circulation/issue.t

Sponsored-by: Koha-Suomi Oy
Comment 4 Emmi Takkinen 2022-07-27 08:24:10 UTC
(In reply to Sally from comment #2)
> I like this idea - but the patch doesn't currently apply.
> 
> CONFLICT (content): Merge conflict in C4/Circulation.pm
> error: Failed to merge in the changes.

Patch rebased.
Comment 5 ByWater Sandboxes 2022-07-27 09:42:02 UTC
Created attachment 138171 [details] [review]
Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description

This can be used to instruct staff how the item should handled when
it's checked in. For example items notforloan status has been
changed as "Invoiced item" while item has been on loan. When it's
checked in staff sees that they should put item aside for further
processing.

To test:
1. Apply patch and update database if needed
2. Set items notforloan status as -1 (or create new one)
3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin
4. Check item out for patron.
5. Check item in.
=> Description of notforloan status should be displayed.
=> Confirm notforloan status hasn't changed.

Also prove t/db_dependent/Circulation/issue.t

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 6 Sally 2022-07-27 09:48:02 UTC
Works as described, signing off.  Thanks for the patch!

The display of the not for loan status for the staff on check in will be particularly useful when we get a publisher recall.
Comment 7 Fridolin Somers 2022-08-13 08:37:52 UTC
Careful Bug 25560 is also modifying this preference