| Summary: | Convert catalog merge page tabs to Bootstrap | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | kyle, martin.renvoize, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 29226 | ||
| Attachments: |
Bug 30434: Convert catalog merge page tabs to Bootstrap
Bug 30434: Convert catalog merge page tabs to Bootstrap Bug 30434: Convert catalog merge page tabs to Bootstrap |
||
|
Description
Owen Leonard
2022-04-01 13:19:37 UTC
Created attachment 132868 [details] [review] Bug 30434: Convert catalog merge page tabs to Bootstrap This patch updates the catalog merge template so that it uses Bootstrap tabs instead of jQueryUI. Some JavaScript is modified to accommodate the new DOM structure. The patch also makes a minor HTML correction, adding a missing "</ol>". To test, apply the patch and search the catalog in the staff client. - In the search results, check the checkbox for two records. - Choose Edit -> Merge records. - Click next to accept the merge reference selection. - On the next page you should see two tabs under "Source records." Confirm that they work correctly. - All checkboxes in the first tab should be checked by default. - Confirm that tag and subfield selection still works correctly. Created attachment 133278 [details] [review] Bug 30434: Convert catalog merge page tabs to Bootstrap This patch updates the catalog merge template so that it uses Bootstrap tabs instead of jQueryUI. Some JavaScript is modified to accommodate the new DOM structure. The patch also makes a minor HTML correction, adding a missing "</ol>". To test, apply the patch and search the catalog in the staff client. - In the search results, check the checkbox for two records. - Choose Edit -> Merge records. - Click next to accept the merge reference selection. - On the next page you should see two tabs under "Source records." Confirm that they work correctly. - All checkboxes in the first tab should be checked by default. - Confirm that tag and subfield selection still works correctly. Created attachment 133482 [details] [review] Bug 30434: Convert catalog merge page tabs to Bootstrap This patch updates the catalog merge template so that it uses Bootstrap tabs instead of jQueryUI. Some JavaScript is modified to accommodate the new DOM structure. The patch also makes a minor HTML correction, adding a missing "</ol>". To test, apply the patch and search the catalog in the staff client. - In the search results, check the checkbox for two records. - Choose Edit -> Merge records. - Click next to accept the merge reference selection. - On the next page you should see two tabs under "Source records." Confirm that they work correctly. - All checkboxes in the first tab should be checked by default. - Confirm that tag and subfield selection still works correctly. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> All works as expected.. being bold and going straight for PQA here as it's a simple patch and I can't find any regressions. Pushed to master for 22.05, thanks to everybody involved [U+1F984] |