Bug 33591 - Cannot merge bibliographic records
Summary: Cannot merge bibliographic records
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Jonathan Druart
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32571
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-23 10:00 UTC by Katrin Fischer
Modified: 2024-07-04 20:38 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Circulation function:


Attachments
Bug 33591: Restore auto-select of checkboxes of src record when merging (1.37 KB, patch)
2023-05-03 14:55 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33591: Restore auto-select of checkboxes of src record when merging (1.42 KB, patch)
2023-05-03 21:42 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-04-23 10:00:04 UTC
When trying to merge 2 bibliographic records in Koha, there is an error complaining about missing fields:

Following required fields are missing:
	- 245
	- 003
	- 005
	- 008
	- 040

Of those fields only 003 is really missing. The other fields are all present in both records to be merged, but would only be needed in the 'winning' record to begin with.

Also: I am merging with the framework Booklets and 003 is not a mandatory field for "Books, Booklets, Workbooks". When I edit the record in cataloguing, it saves without any missing fields error.
Comment 1 Jonathan Druart 2023-05-03 14:51:11 UTC
I am not sure I understand what you are describing, but I found a bug, the checkboxes from the source record are no longer selected by default.

Is that your problem?
Comment 2 Jonathan Druart 2023-05-03 14:55:16 UTC
Created attachment 150593 [details] [review]
Bug 33591: Restore auto-select of checkboxes of src record when merging

When merging bib records the first tab (the source record) should have
all the checkboxes checked by default.
Comment 3 Jonathan Druart 2023-05-03 14:56:01 UTC
Not sure about the dependency, is bug 29226 really introduced this regression?
Comment 4 Katrin Fischer 2023-05-03 19:28:05 UTC
I think the checkboxes could well be it, I'll try to test. 
It could also be another form of bug 33590, related to the other tab changes.
Comment 5 Katrin Fischer 2023-05-03 21:42:06 UTC
Created attachment 150621 [details] [review]
Bug 33591: Restore auto-select of checkboxes of src record when merging

When merging bib records the first tab (the source record) should have
all the checkboxes checked by default.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2023-05-03 21:43:21 UTC
The change follows the pattern of the related bug 33590 and also works like a charm. Going straight to PQA.
Comment 7 Tomás Cohen Arazi (tcohen) 2023-05-09 14:00:17 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Matt Blenkinsop 2023-05-15 10:36:38 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 9 Lucas Gass (lukeg) 2023-06-15 16:44:09 UTC
Missing dependencies for 22.05.x, no backport.
Comment 10 Fridolin Somers 2023-08-09 19:47:05 UTC
I'd say this is more caused by Bug 30434