Summary: | Accordion on letter.tt is broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Notices | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, kyle, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.06
|
|
Circulation function: | |||
Bug Depends on: | 30011 | ||
Bug Blocks: | |||
Attachments: |
Bug 30509: Fix configuration of Notices accordion widget
Bug 30509: Fix configuration of Notices accordion widget Bug 30509: Fix configuration of Notices accordion widget |
Description
Lucas Gass (lukeg)
2022-04-11 15:35:25 UTC
Created attachment 133196 [details] [review] Bug 30509: Fix configuration of Notices accordion widget The jQueryUI upgrade broke the Accordion on the notices edit page. I'm not sure why, but defining a "header" option in the accordion configuration fixes it. To test, apply the patch and test the notices edit page both with and without TranslateNotices and multiple languages installed. In both cases the different sections (Email, Print, SMS) should open and close correctly. Created attachment 133197 [details] [review] Bug 30509: Fix configuration of Notices accordion widget The jQueryUI upgrade broke the Accordion on the notices edit page. I'm not sure why, but defining a "header" option in the accordion configuration fixes it. To test, apply the patch and test the notices edit page both with and without TranslateNotices and multiple languages installed. In both cases the different sections (Email, Print, SMS) should open and close correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 133392 [details] [review] Bug 30509: Fix configuration of Notices accordion widget The jQueryUI upgrade broke the Accordion on the notices edit page. I'm not sure why, but defining a "header" option in the accordion configuration fixes it. To test, apply the patch and test the notices edit page both with and without TranslateNotices and multiple languages installed. In both cases the different sections (Email, Print, SMS) should open and close correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Hmm, fix works as described and I'm not seeing any other regressions.. No idea why it works though, I can't find anything in the jQueryUI docs to suggest this is required.. But.. it works.. so Passing QA Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.06 Missing dependency, not backported to 21.05 |