At '/cgi-bin/koha/tools/letter.pl' the accordion for changing between Email, Print, SMS notice templates is broken. All of the templates are showing at the same time. It looks to be related to a JS error coming from letter.js: Uncaught TypeError: t.find(...).even is not a function
Created attachment 133196 [details] [review] Bug 30509: Fix configuration of Notices accordion widget The jQueryUI upgrade broke the Accordion on the notices edit page. I'm not sure why, but defining a "header" option in the accordion configuration fixes it. To test, apply the patch and test the notices edit page both with and without TranslateNotices and multiple languages installed. In both cases the different sections (Email, Print, SMS) should open and close correctly.
Created attachment 133197 [details] [review] Bug 30509: Fix configuration of Notices accordion widget The jQueryUI upgrade broke the Accordion on the notices edit page. I'm not sure why, but defining a "header" option in the accordion configuration fixes it. To test, apply the patch and test the notices edit page both with and without TranslateNotices and multiple languages installed. In both cases the different sections (Email, Print, SMS) should open and close correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 133392 [details] [review] Bug 30509: Fix configuration of Notices accordion widget The jQueryUI upgrade broke the Accordion on the notices edit page. I'm not sure why, but defining a "header" option in the accordion configuration fixes it. To test, apply the patch and test the notices edit page both with and without TranslateNotices and multiple languages installed. In both cases the different sections (Email, Print, SMS) should open and close correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Hmm, fix works as described and I'm not seeing any other regressions.. No idea why it works though, I can't find anything in the jQueryUI docs to suggest this is required.. But.. it works.. so Passing QA
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.06
Missing dependency, not backported to 21.05